Bug 44913 – add missing parts of didFinishDocumentLoadForFrame

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alice Liu]

Created attachment 65984 [details]
patch

Support for didFinishDocumentLoadForFrame is currently only in InjectedBundlePageLoaderClient.  Add the rest of it.

[Darin Adler]

Comment on attachment 65984 [details]
patch

Changes are good. But need a change log.

[Adam Roben (:aroben)]

I think you also need to update DRT (and maybe MiniBrowser) to account for the new callback.

[Early Warning System Bot]

Attachment 65984 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3815184

[Sam Weinig]

(In reply to comment #2)
> I think you also need to update DRT (and maybe MiniBrowser) to account for the new callback.

And qwkpage.cpp.

[Alice Liu]

Created attachment 65997 [details]
patch with changelog, WKTR, MiniBrowser, and qt changes

thanks everyone!

[WebKit Review Bot]

Attachment 65997 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:91:  Extra space between WKPageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:77:  Extra space between WKBundlePageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame  [whitespace/declaration] [3]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alice Liu]

Created attachment 65998 [details]
(for real this time) patch with changelog, WKTR, MiniBrowser, and qt changes

lol what is wrong with me today

[WebKit Review Bot]

Attachment 65998 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:91:  Extra space between WKPageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:77:  Extra space between WKBundlePageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame  [whitespace/declaration] [3]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 65997 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3854159

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/66448 broke Qt build:

../../../WebKit2/UIProcess/API/qt/qwkpage.cpp: In constructor ‘QWKPage::QWKPage(OpaqueWKPageNamespace*)’:
../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:228: error: ‘qt_wk_didFinishDocumentLoadForFrame’ was not declared in this scope

[Csaba Osztrogonác]

(In reply to comment #10)
> http://trac.webkit.org/changeset/66448 broke Qt build:
> 
> ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp: In constructor ‘QWKPage::QWKPage(OpaqueWKPageNamespace*)’:
> ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:228: error: ‘qt_wk_didFinishDocumentLoadForFrame’ was not declared in this scope

Fix landed in http://trac.webkit.org/changeset/66466

[Alice Liu]

my apologies.  thank you for the qt build fix. 

(In reply to comment #11)