44905 – [review tool] Let reviewer select how much context to show in snippet

Bug 44905 - [review tool] Let reviewer select how much context to show in snippet

Summary: [review tool] Let reviewer select how much context to show in snippet

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Other OS X 10.5

Importance:	P2 Normal
Assignee:	Adam Barth

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-30 15:17 PDT by Adam Barth
Modified:	2010-08-30 16:24 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (7.85 KB, patch) 2010-08-30 15:20 PDT, Adam Barth	eric: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adam Barth 2010-08-30 15:17:25 PDT

[review tool] Let reviewer select how much context to show in snippet

Comment 1 Adam Barth 2010-08-30 15:20:16 PDT

Created attachment 65969 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-08-30 15:51:49 PDT

Comment on attachment 65969 [details]
Patch

LGTM.

Comment 3 Adam Barth 2010-08-30 15:52:40 PDT

Committed r66420: <http://trac.webkit.org/changeset/66420>

Comment 4 WebKit Review Bot 2010-08-30 16:24:58 PDT

http://trac.webkit.org/changeset/66420 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66418
http://trac.webkit.org/changeset/66419
http://trac.webkit.org/changeset/66420
http://trac.webkit.org/changeset/66421