RESOLVED FIXED Bug 44900
[GTK] Isolate all GTK+ typedefs into one file 
https://bugs.webkit.org/show_bug.cgi?id=44900
Summary [GTK] Isolate all GTK+ typedefs into one file
Martin Robinson
Reported 2010-08-30 14:56:34 PDT
We often forward declare GLib/GTK+ typdefs to avoid having GLib/GTK+ headers in our header files, for the sake of build speed. Not only does this pepper noise through all header files, it also means we'll have to update them if the GTK+ definitions ever change. I propose having these all in one file, automatically included via config where they can be managed more easily.
Attachments
Patch for this issue (15.98 KB, patch)
2010-08-30 15:58 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-08-30 15:58:08 PDT
Created attachment 65973 [details] Patch for this issue
WebKit Review Bot
Comment 2 2010-08-30 16:00:49 PDT
Attachment 65973 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/gtk/GtkTypedefs.h:39: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/wtf/gtk/GtkTypedefs.h:74: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2010-08-30 16:02:46 PDT
These typedefs are forward declarations, so the style errors are false positives.
Gustavo Noronha (kov)
Comment 4 2010-08-31 11:55:51 PDT
Comment on attachment 65973 [details] Patch for this issue OK
Martin Robinson
Comment 5 2010-08-31 14:23:25 PDT
Comment on attachment 65973 [details] Patch for this issue Clearing flags on attachment: 65973 Committed r66531: <http://trac.webkit.org/changeset/66531>
Martin Robinson
Comment 6 2010-08-31 14:23:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.