We often forward declare GLib/GTK+ typdefs to avoid having GLib/GTK+ headers in our header files, for the sake of build speed. Not only does this pepper noise through all header files, it also means we'll have to update them if the GTK+ definitions ever change. I propose having these all in one file, automatically included via config where they can be managed more easily.
Created attachment 65973 [details] Patch for this issue
Attachment 65973 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/gtk/GtkTypedefs.h:39: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/wtf/gtk/GtkTypedefs.h:74: cairo_rectangle_int_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
These typedefs are forward declarations, so the style errors are false positives.
Comment on attachment 65973 [details] Patch for this issue OK
Comment on attachment 65973 [details] Patch for this issue Clearing flags on attachment: 65973 Committed r66531: <http://trac.webkit.org/changeset/66531>
All reviewed patches have been landed. Closing bug.