RESOLVED FIXED44868
[Qt] Add new window menu to MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=44868
Summary [Qt] Add new window menu to MiniBrowser
Zoltan Horvath
Reported 2010-08-29 22:43:14 PDT
Implement newWindow function and add a menu item for opening new window in MiniBrowser.
Attachments
proposed patch (2.78 KB, patch)
2010-08-30 05:51 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
updated proposed patch (3.06 KB, patch)
2010-08-30 06:45 PDT, Zoltan Horvath 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2010-08-30 05:51:51 PDT
Created attachment 65908 [details] proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-08-30 06:04:29 PDT
Comment on attachment 65908 [details] proposed patch Where are you freeing the newly allocated windows?
Zoltan Horvath
Comment 3 2010-08-30 06:45:49 PDT
Created attachment 65910 [details] updated proposed patch Thanks! I've set Qt::WA_DeleteOnClose in MiniBrowser's constructor.
Kenneth Rohde Christiansen
Comment 4 2010-08-30 06:48:09 PDT
Comment on attachment 65910 [details] updated proposed patch 32 #include <QDebug> Why?
Zoltan Horvath
Comment 5 2010-08-30 06:51:08 PDT
Because it's an experimental browser. :) I'm going to remove it on land!
Zoltan Horvath
Comment 6 2010-08-30 07:11:51 PDT
http://trac.webkit.org/changeset/66386 Committed revision 66386.
Note You need to log in before you can comment on or make changes to this bug.