Bug 44843 - REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
Summary: REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 43191
  Show dependency tree / graph
 
Reported: 2010-08-29 14:31 PDT by Csaba Osztrogonác
Modified: 2010-08-30 02:46 PDT (History)
6 users (show)

See Also:

Attachments
proposed fix (1.55 KB, patch)
2010-08-29 14:33 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
proposed fix 2 (1.40 KB, patch)
2010-08-29 23:52 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-08-29 14:31:22 PDT 
gcc warnings:
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||
../../../WebCore/editing/ApplyStyleCommand.cpp:1210: warning: suggest parentheses around && within ||
Comment 1 Csaba Osztrogonác 2010-08-29 14:33:29 PDT 
Created attachment 65862 [details]
proposed fix
Comment 2 Ryosuke Niwa 2010-08-29 14:42:44 PDT 
Comment on attachment 65862 [details]
proposed fix

> WebCore/editing/ApplyStyleCommand.cpp:1210
> +            || (equivalent.attribute && !element->hasAttribute(*equivalent.attribute)))
Looks good to me.  Sorry about the regression.
Comment 3 Csaba Osztrogonác 2010-08-29 14:47:48 PDT 
(In reply to comment #2)
> Looks good to me.  Sorry about the regression.
Not problem, now it isn't a big problem, but we are going to 
treat warnings as errors on Qt port. (with gcc -Werror option)
After that all warnings will cause a build fail. 
( See https://bugs.webkit.org/show_bug.cgi?id=43191 )
Comment 4 Csaba Osztrogonác 2010-08-29 15:09:17 PDT 
Comment on attachment 65862 [details]
proposed fix

Clearing flags on attachment: 65862

Committed r66338: <http://trac.webkit.org/changeset/66338>
Comment 5 Csaba Osztrogonác 2010-08-29 15:09:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-08-29 15:51:44 PDT 
http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release
Comment 7 Csaba Osztrogonác 2010-08-29 23:52:14 PDT 
Created attachment 65884 [details]
proposed fix 2

Crazy gcc, there are one more warning in line 1208, but it reported line 1209 :
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||
Comment 8 Csaba Osztrogonác 2010-08-29 23:53:01 PDT 
(In reply to comment #6)
> http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release

No, it isn't.
Comment 9 Csaba Osztrogonác 2010-08-30 02:46:31 PDT 
Comment on attachment 65884 [details]
proposed fix 2

Landed in http://trac.webkit.org/changeset/66378