Bug 44843 – REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Csaba Osztrogonác]

gcc warnings:
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||
../../../WebCore/editing/ApplyStyleCommand.cpp:1210: warning: suggest parentheses around && within ||

[Csaba Osztrogonác]

Created attachment 65862 [details]
proposed fix

[Ryosuke Niwa]

Comment on attachment 65862 [details]
proposed fix

> WebCore/editing/ApplyStyleCommand.cpp:1210
> +            || (equivalent.attribute && !element->hasAttribute(*equivalent.attribute)))
Looks good to me.  Sorry about the regression.

[Csaba Osztrogonác]

(In reply to comment #2)
> Looks good to me.  Sorry about the regression.
Not problem, now it isn't a big problem, but we are going to 
treat warnings as errors on Qt port. (with gcc -Werror option)
After that all warnings will cause a build fail. 
( See https://bugs.webkit.org/show_bug.cgi?id=43191 )

[Csaba Osztrogonác]

Comment on attachment 65862 [details]
proposed fix

Clearing flags on attachment: 65862

Committed r66338: <http://trac.webkit.org/changeset/66338>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release

[Csaba Osztrogonác]

Created attachment 65884 [details]
proposed fix 2

Crazy gcc, there are one more warning in line 1208, but it reported line 1209 :
../../../WebCore/editing/ApplyStyleCommand.cpp:1209: warning: suggest parentheses around && within ||

[Csaba Osztrogonác]

(In reply to comment #6)
> http://trac.webkit.org/changeset/66338 might have broken Qt Linux Release

No, it isn't.

[Csaba Osztrogonác]

Comment on attachment 65884 [details]
proposed fix 2

Landed in http://trac.webkit.org/changeset/66378