RESOLVED FIXED Bug 44835
Awesomify pretty-diff based review tool 
https://bugs.webkit.org/show_bug.cgi?id=44835
Summary Awesomify pretty-diff based review tool
Adam Barth
Reported 2010-08-29 00:55:16 PDT
The current pretty-diff review tool is ok. We can make it much more awesome with a little work. On the agenda: 1) Fix the "giant comment" bug. 2) View line-by-line comments in context. 3) Threaded line-by-line comments in patch.
Attachments
work-in-progress script (5.50 KB, text/plain)
2010-08-29 00:55 PDT, Adam Barth 		no flags
Details
more work-in-progress (3.61 KB, text/plain)
2010-08-29 01:25 PDT, Adam Barth 		no flags
Details
front-end mostly done (needs bugzilla integration) (4.77 KB, text/plain)
2010-08-29 02:09 PDT, Adam Barth 		no flags
Details
potentially ready (5.37 KB, application/x-javascript)
2010-08-29 09:43 PDT, Adam Barth 		no flags
Details
Patch (152.76 KB, patch)
2010-08-29 09:52 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-29 00:55:43 PDT
Created attachment 65848 [details] work-in-progress script
Adam Barth
Comment 2 2010-08-29 01:25:25 PDT
Created attachment 65849 [details] more work-in-progress
Adam Barth
Comment 3 2010-08-29 02:09:40 PDT
Created attachment 65850 [details] front-end mostly done (needs bugzilla integration)
Adam Barth
Comment 4 2010-08-29 09:43:19 PDT
Created attachment 65854 [details] potentially ready
Adam Barth
Comment 5 2010-08-29 09:52:30 PDT
Created attachment 65855 [details] Patch
Adam Barth
Comment 6 2010-08-29 09:53:16 PDT
This version don't have support for parsing back the threaded discussion, but I'll add that in the next patch.
Eric Seidel (no email)
Comment 7 2010-08-29 10:58:24 PDT
Comment on attachment 65855 [details] Patch I'm not sure I can really review much here. Lets just try it, and change/rollout if it's wrong.
Adam Barth
Comment 8 2010-08-29 11:00:09 PDT
Committed r66332: <http://trac.webkit.org/changeset/66332>
Adam Barth
Comment 9 2010-08-29 11:06:22 PDT
Comment on attachment 65855 [details] Patch > BugsSite/ChangeLog:5 > + Awesomify pretty-diff based review tool This is a test.
WebKit Review Bot
Comment 10 2010-08-29 11:30:32 PDT
http://trac.webkit.org/changeset/66332 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.