Bug 44811 - fast/loader/input-element-page-cache-crash.html fails on Chromium
Summary: fast/loader/input-element-page-cache-crash.html fails on Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 19:28 PDT by Mihai Parparita
Modified: 2010-08-29 16:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2010-08-27 19:31 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2010-08-29 12:30 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-08-27 19:28:42 PDT 
fast/loader/input-element-page-cache-crash.html fails on Chromium
Comment 1 Mihai Parparita 2010-08-27 19:31:22 PDT 
Created attachment 65804 [details]
Patch
Comment 2 Mihai Parparita 2010-08-27 19:33:03 PDT 
Tony, since you're the gardener, can you take a look at this?
Comment 3 Tony Chang 2010-08-28 11:41:39 PDT 
Comment on attachment 65804 [details]
Patch

Should the test initialize sessionStorage.finishTest to false?  As in, if I run the test twice in a row, will sessionStorage.finishTest be confused?
Comment 4 Tony Chang 2010-08-28 11:42:07 PDT 
Alternately, if another test used the same variable, could that confuse this test?
Comment 5 Mihai Parparita 2010-08-29 12:30:29 PDT 
Created attachment 65860 [details]
Patch
Comment 6 Mihai Parparita 2010-08-29 12:32:37 PDT 
I had assumed that sessionStorage gets reset between tests, and I even tried using --iterations 2 when running this test to see if it passes if run twice. However, it turned out that the test output was the same whether it navigated to the page and back or just finished immediately. I added some extra logging to make sure that it actually goes through the steps, and sure enough it failed. I added a cleanup step at the end which removes the sessionStorage variable, and now it passes when run twice (and still passes with the Chromium DRT).
Comment 7 Tony Chang 2010-08-29 16:07:00 PDT 
Comment on attachment 65860 [details]
Patch

LGTM
Comment 8 WebKit Commit Bot 2010-08-29 16:57:05 PDT 
Comment on attachment 65860 [details]
Patch

Clearing flags on attachment: 65860

Committed r66340: <http://trac.webkit.org/changeset/66340>
Comment 9 WebKit Commit Bot 2010-08-29 16:57:10 PDT 
All reviewed patches have been landed.  Closing bug.