WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44810
Add UserContent API to WebKit2 InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=44810
Summary
Add UserContent API to WebKit2 InjectedBundle
Sam Weinig
Reported
2010-08-27 18:49:21 PDT
Add UserContent API to WebKit2 InjectedBundle. In the first pass, I will only add it to the InjectedBundle, but we can consider whether we want to provide a convenient way of doing much of this from the UIProcess if this turns out to be too cumbersome.
Attachments
Patch
(13.69 KB, patch)
2010-08-27 18:53 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-08-27 18:53:13 PDT
Created
attachment 65802
[details]
Patch
Sam Weinig
Comment 2
2010-08-27 18:58:43 PDT
<
rdar://problem/8367587
>
mitz
Comment 3
2010-08-27 19:13:39 PDT
Comment on
attachment 65802
[details]
Patch
> +static PassOwnPtr<Vector<String> > toStringVector(ImmutableArray* patterns) > +{ > + size_t size = patterns->size(); > + if (!size) > + return 0; > + > + Vector<String>* patternsVector = new Vector<String>;
Reserve initial capacity here…
> + for (size_t i = 0; i < size; ++i) { > + WebString* entry = patterns->at<WebString>(i); > + if (entry) > + patternsVector->append(entry->string());
…unchecked append here.
Sam Weinig
Comment 4
2010-08-27 19:16:55 PDT
Landed in
r66292
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug