Bug 44796 - [chromium] Rename webcore to 'webcore_remaining' and create a meta-target webcore that inherits from every webcore_XXX targets.
Summary: [chromium] Rename webcore to 'webcore_remaining' and create a meta-target web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 44786
Blocks: 44812
  Show dependency treegraph
 
Reported: 2010-08-27 14:39 PDT by Marc-Antoine Ruel
Modified: 2010-08-29 23:33 PDT (History)
2 users (show)

See Also:


Attachments
move sources to webcore_remaining (5.45 KB, patch)
2010-08-27 14:42 PDT, Marc-Antoine Ruel
tkent: review+
tkent: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Ruel 2010-08-27 14:39:01 PDT
Rename webcore to 'webcore_remaining'.
Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1)
Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore

Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible.

Original review: http://codereview.chromium.org/3278002
Comment 1 Marc-Antoine Ruel 2010-08-27 14:42:19 PDT
Created attachment 65770 [details]
move sources to webcore_remaining
Comment 2 Kent Tamura 2010-08-29 23:30:03 PDT
Comment on attachment 65770 [details]
move sources to webcore_remaining

r+.
I'll commit this manually because the ChangeLog diff is malformed.
Comment 3 Kent Tamura 2010-08-29 23:33:00 PDT
Landed: http://trac.webkit.org/changeset/66360