Bug 44793 - Move Shader class from platform/graphics/chromium to platform/graphics/gpu
Summary: Move Shader class from platform/graphics/chromium to platform/graphics/gpu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 13:57 PDT by James Robinson
Modified: 2010-08-27 14:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (26.44 KB, patch)
2010-08-27 13:59 PDT, James Robinson 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-08-27 13:57:47 PDT 
Move Shader class from platform/graphics/chromium to platform/graphics/gpu
Comment 1 James Robinson 2010-08-27 13:59:10 PDT 
Created attachment 65763 [details]
Patch
Comment 2 James Robinson 2010-08-27 14:02:07 PDT 
Move this class over just like Texture.

One minor thing I added was making the shader program strings static.  Since they currently point to string literals the "static" keyword on the locals doesn't do much, but if we ever use another string type it will make a difference.
Comment 3 Stephen White 2010-08-27 14:06:14 PDT 
Looks good to me.  Thanks for cleaning this up, James!
Comment 4 Dimitri Glazkov (Google) 2010-08-27 14:10:41 PDT 
Comment on attachment 65763 [details]
Patch

ok.
Comment 5 James Robinson 2010-08-27 14:18:35 PDT 
Committed r66256: <http://trac.webkit.org/changeset/66256>