WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44793
Move Shader class from platform/graphics/chromium to platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=44793
Summary
Move Shader class from platform/graphics/chromium to platform/graphics/gpu
James Robinson
Reported
2010-08-27 13:57:47 PDT
Move Shader class from platform/graphics/chromium to platform/graphics/gpu
Attachments
Patch
(26.44 KB, patch)
2010-08-27 13:59 PDT
,
James Robinson
dglazkov
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2010-08-27 13:59:10 PDT
Created
attachment 65763
[details]
Patch
James Robinson
Comment 2
2010-08-27 14:02:07 PDT
Move this class over just like Texture. One minor thing I added was making the shader program strings static. Since they currently point to string literals the "static" keyword on the locals doesn't do much, but if we ever use another string type it will make a difference.
Stephen White
Comment 3
2010-08-27 14:06:14 PDT
Looks good to me. Thanks for cleaning this up, James!
Dimitri Glazkov (Google)
Comment 4
2010-08-27 14:10:41 PDT
Comment on
attachment 65763
[details]
Patch ok.
James Robinson
Comment 5
2010-08-27 14:18:35 PDT
Committed
r66256
: <
http://trac.webkit.org/changeset/66256
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug