Bug 44787 - [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer are deprecated
Summary: [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer are deprec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 12:34 PDT by Alejandro G. Castro
Modified: 2010-08-30 12:07 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (11.17 KB, patch)
2010-08-28 06:54 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Proposed patch (16.15 KB, patch)
2010-08-28 07:03 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Proposed patch (10.27 KB, patch)
2010-08-28 07:23 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Proposed patch (16.25 KB, patch)
2010-08-28 08:24 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Proposed patch (15.75 KB, patch)
2010-08-28 11:06 PDT, Alejandro G. Castro
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2010-08-27 12:34:14 PDT
We need to avoid them to compile with gtk+-3.0 master branch.
Comment 1 Alejandro G. Castro 2010-08-28 06:54:40 PDT
Created attachment 65819 [details]
Proposed patch
Comment 2 Alejandro G. Castro 2010-08-28 07:03:34 PDT
Created attachment 65820 [details]
Proposed patch

Avoid the git mv
Comment 3 WebKit Review Bot 2010-08-28 07:05:46 PDT
Attachment 65820 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testcopyandpaste.c"
WebKitTools/DumpRenderTree/gtk/EventSender.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/gtk/GtkVersioning.c:53:  Declaration has space between * and variable name in GdkDevice* getDefaultGDKPointerDevice  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:56:  Declaration has space between * and variable name in GdkDeviceManager* manager  [whitespace/declaration] [3]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alejandro G. Castro 2010-08-28 07:22:58 PDT
(In reply to comment #3)
> Attachment 65820 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testcopyandpaste.c"
> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
> WebCore/platform/gtk/GtkVersioning.c:53:  Declaration has space between * and variable name in GdkDevice* getDefaultGDKPointerDevice  [whitespace/declaration] [3]
> WebCore/platform/gtk/GtkVersioning.c:56:  Declaration has space between * and variable name in GdkDeviceManager* manager  [whitespace/declaration] [3]
> Total errors found: 3 in 11 files
> 

Are these correct?
Comment 5 Alejandro G. Castro 2010-08-28 07:23:56 PDT
Created attachment 65821 [details]
Proposed patch
Comment 6 WebKit Review Bot 2010-08-28 08:11:19 PDT
Attachment 65821 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3867064
Comment 7 Alejandro G. Castro 2010-08-28 08:24:41 PDT
Created attachment 65824 [details]
Proposed patch
Comment 8 WebKit Review Bot 2010-08-28 08:40:47 PDT
Attachment 65824 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3830056
Comment 9 Alejandro G. Castro 2010-08-28 11:06:37 PDT
Created attachment 65833 [details]
Proposed patch

I think the patch is correct, maybe the Plos if the bot is not doing a clean build could be causing the problem, recall to make a fresh rebuild in the bots when uploading this patch. I've removed config.h and JavascriptCore include using to find the file.
Comment 10 WebKit Review Bot 2010-08-28 11:18:46 PDT
Attachment 65833 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3840071
Comment 11 Martin Robinson 2010-08-29 01:29:05 PDT
Comment on attachment 65833 [details]
Proposed patch

 1112 Programs_unittests_testcopyandpaste_SOURCES = WebKit/gtk/tests/testcopyandpaste.c \
 1113 					WebCore/platform/gtk/GtkVersioning.c
 1114 Programs_unittests_testcopyandpaste_CFLAGS = $(webkit_tests_cflags) \
 1115 					-I$(srcdir)/WebCore/platform/gtk \
 1116 					-I$(srcdir)/WebCore

It's hard to tell from the diff, but these lines should only be indented one tab to match the rest of the file.

Otherwise this looks good. If the bots need a clean build, do you mind cleaning them after you land? Thanks!
Comment 12 Alejandro G. Castro 2010-08-30 12:07:40 PDT
landed http://trac.webkit.org/changeset/66398