Bug 44787 – [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer are deprecated

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alejandro G. Castro]

We need to avoid them to compile with gtk+-3.0 master branch.

[Alejandro G. Castro]

Created attachment 65819 [details]
Proposed patch

[Alejandro G. Castro]

Created attachment 65820 [details]
Proposed patch

Avoid the git mv

[WebKit Review Bot]

Attachment 65820 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testcopyandpaste.c"
WebKitTools/DumpRenderTree/gtk/EventSender.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/gtk/GtkVersioning.c:53:  Declaration has space between * and variable name in GdkDevice* getDefaultGDKPointerDevice  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:56:  Declaration has space between * and variable name in GdkDeviceManager* manager  [whitespace/declaration] [3]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alejandro G. Castro]

(In reply to comment #3)
> Attachment 65820 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testcopyandpaste.c"
> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
> WebCore/platform/gtk/GtkVersioning.c:53:  Declaration has space between * and variable name in GdkDevice* getDefaultGDKPointerDevice  [whitespace/declaration] [3]
> WebCore/platform/gtk/GtkVersioning.c:56:  Declaration has space between * and variable name in GdkDeviceManager* manager  [whitespace/declaration] [3]
> Total errors found: 3 in 11 files
> 

Are these correct?

[Alejandro G. Castro]

Created attachment 65821 [details]
Proposed patch

[WebKit Review Bot]

Attachment 65821 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3867064

[Alejandro G. Castro]

Created attachment 65824 [details]
Proposed patch

[WebKit Review Bot]

Attachment 65824 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3830056

[Alejandro G. Castro]

Created attachment 65833 [details]
Proposed patch

I think the patch is correct, maybe the Plos if the bot is not doing a clean build could be causing the problem, recall to make a fresh rebuild in the bots when uploading this patch. I've removed config.h and JavascriptCore include using to find the file.

[WebKit Review Bot]

Attachment 65833 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3840071

[Martin Robinson]

Comment on attachment 65833 [details]
Proposed patch

 1112 Programs_unittests_testcopyandpaste_SOURCES = WebKit/gtk/tests/testcopyandpaste.c \
 1113 					WebCore/platform/gtk/GtkVersioning.c
 1114 Programs_unittests_testcopyandpaste_CFLAGS = $(webkit_tests_cflags) \
 1115 					-I$(srcdir)/WebCore/platform/gtk \
 1116 					-I$(srcdir)/WebCore

It's hard to tell from the diff, but these lines should only be indented one tab to match the rest of the file.

Otherwise this looks good. If the bots need a clean build, do you mind cleaning them after you land? Thanks!

[Alejandro G. Castro]

landed http://trac.webkit.org/changeset/66398