Bug 44782 – [GTK] ScrollbarThemeGtk should respond to theme changes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

Scrollbar.cpp never expects scrollbars to change size, so even though theme changes currently trigger a re-layout, the scrollbar widget size does not change. We need to add some special code in ScrollbarThemeGtk which resizes all scrollbars when the theme specifies a different size.

[Martin Robinson]

Created attachment 65746 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 65746 [details]
Patch

 89     // If the theme changed, update the thickness of every scrollbar widget.
 90     // The platform-independent scrollbar code isn't yet smart enough to
 91     // get this information when it paints.
 92     HashSet<Scrollbar*>::iterator end = gScrollbars->end();
 93     for (HashSet<Scrollbar*>::iterator it = gScrollbars->begin(); it != end; ++it) {
 94         Scrollbar* scrollbar = (*it);

Saying 'If the theme changed' seems to imply that we're depending on a conditional, but if we're in this function it's because the theme has changed, so I'd suggest only stating what is being done. Looks good otherwise!

[Martin Robinson]

> Saying 'If the theme changed' seems to imply that we're depending on a conditional, but if we're in this function it's because the theme has changed, so I'd suggest only stating what is being done. Looks good otherwise!

Okay. I'll fix this before landing. Thanks for the review. :)

[Martin Robinson]

Committed r66540: <http://trac.webkit.org/changeset/66540>