Bug 44764 - [BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
Summary: [BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-08-27 06:47 PDT by Kwang Yul Seo
Modified: 2010-09-14 19:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2010-08-27 06:51 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2010-08-27 06:57 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-08-27 06:47:56 PDT
Add IMemGroup and IMemSpace to OwnPtr type.
Comment 1 Kwang Yul Seo 2010-08-27 06:51:09 PDT
Created attachment 65709 [details]
Patch

IMemSpace and IMemGroup are used to implement WTF PageAllocation and PageReservation.
Comment 2 WebKit Review Bot 2010-08-27 06:54:29 PDT
Attachment 65709 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/brew/OwnPtrBrew.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kwang Yul Seo 2010-08-27 06:57:08 PDT
Created attachment 65710 [details]
Patch

Fix style error.
Comment 4 Kent Tamura 2010-09-13 22:37:44 PDT
Comment on attachment 65710 [details]
Patch

> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 66217)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> +2010-08-27  Hyung Song  <beergun@company100.net>
> +

Just confirmation: Wasn't it written by Kwang?
Comment 5 Kwang Yul Seo 2010-09-14 18:36:44 PDT
(In reply to comment #4)
> (From update of attachment 65710 [details])
> > Index: JavaScriptCore/ChangeLog
> > ===================================================================
> > --- JavaScriptCore/ChangeLog	(revision 66217)
> > +++ JavaScriptCore/ChangeLog	(working copy)
> > @@ -1,3 +1,14 @@
> > +2010-08-27  Hyung Song  <beergun@company100.net>
> > +
> 
> Just confirmation: Wasn't it written by Kwang?


The ChangeLog is correct. The patch is written by Hyung and I submitted the patch instead of him. He will submit patches by himself next time.
Comment 6 Kent Tamura 2010-09-14 18:39:53 PDT
> The ChangeLog is correct. The patch is written by Hyung and I submitted the patch instead of him. He will submit patches by himself next time.

ok, I understand.
Comment 7 WebKit Commit Bot 2010-09-14 19:31:54 PDT
Comment on attachment 65710 [details]
Patch

Clearing flags on attachment: 65710

Committed r67529: <http://trac.webkit.org/changeset/67529>
Comment 8 WebKit Commit Bot 2010-09-14 19:31:59 PDT
All reviewed patches have been landed.  Closing bug.