RESOLVED FIXED 44764
[BREWMP] Add IMemGroup and IMemSpace to OwnPtr type. 
https://bugs.webkit.org/show_bug.cgi?id=44764
Summary [BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
Kwang Yul Seo
Reported 2010-08-27 06:47:56 PDT
Add IMemGroup and IMemSpace to OwnPtr type.
Attachments
Patch (1.96 KB, patch)
2010-08-27 06:51 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2010-08-27 06:57 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-08-27 06:51:09 PDT
Created attachment 65709 [details] Patch IMemSpace and IMemGroup are used to implement WTF PageAllocation and PageReservation.
WebKit Review Bot
Comment 2 2010-08-27 06:54:29 PDT
Attachment 65709 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/brew/OwnPtrBrew.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 3 2010-08-27 06:57:08 PDT
Created attachment 65710 [details] Patch Fix style error.
Kent Tamura
Comment 4 2010-09-13 22:37:44 PDT
Comment on attachment 65710 [details] Patch > Index: JavaScriptCore/ChangeLog > =================================================================== > --- JavaScriptCore/ChangeLog (revision 66217) > +++ JavaScriptCore/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2010-08-27 Hyung Song <beergun@company100.net> > + Just confirmation: Wasn't it written by Kwang?
Kwang Yul Seo
Comment 5 2010-09-14 18:36:44 PDT
(In reply to comment #4) > (From update of attachment 65710 [details]) > > Index: JavaScriptCore/ChangeLog > > =================================================================== > > --- JavaScriptCore/ChangeLog (revision 66217) > > +++ JavaScriptCore/ChangeLog (working copy) > > @@ -1,3 +1,14 @@ > > +2010-08-27 Hyung Song <beergun@company100.net> > > + > > Just confirmation: Wasn't it written by Kwang? The ChangeLog is correct. The patch is written by Hyung and I submitted the patch instead of him. He will submit patches by himself next time.
Kent Tamura
Comment 6 2010-09-14 18:39:53 PDT
> The ChangeLog is correct. The patch is written by Hyung and I submitted the patch instead of him. He will submit patches by himself next time. ok, I understand.
WebKit Commit Bot
Comment 7 2010-09-14 19:31:54 PDT
Comment on attachment 65710 [details] Patch Clearing flags on attachment: 65710 Committed r67529: <http://trac.webkit.org/changeset/67529>
WebKit Commit Bot
Comment 8 2010-09-14 19:31:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.