Bug 44736 – Web Inspector: attribute nodes don't get rendered in the console

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ojan Vafai]

Created attachment 65652 [details]
screenshot

Type "document.createAttribute('id')" into the console. You get a blank line. You should get a node like any other node.

[Joseph Pecoraro]

Thanks Ojan. Consider using the http://webkit.org/new-inspector-bug link, available
on the Bugzilla "New Bug" page https://bugs.webkit.org/enter_bug.cgi

[Joseph Pecoraro]

Looks like we don't support just printing an attribute in
WebInspector.ElementsTreeElement.prototype._nodeTitleInfo.
It should be added. case Node.ATTRIBUTE_NODE is missing from that long switch.
http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/ElementsTreeOutline.js#L1253

[Joseph Pecoraro]

Created attachment 65672 [details]
[PATCH] Print Out Attributes

Extends the console-format test to test for attributes. Image up soon.

[Joseph Pecoraro]

Created attachment 65674 [details]
[IMAGE] Results After Patch

[Pavel Feldman]

Comment on attachment 65672 [details]
[PATCH] Print Out Attributes

Thanks for the test with this.

[Ojan Vafai]

This is definitely an improvement, but it seems to me that we'd want to output an object in the same way we do with Elements so that you can inspect the attribute object. Is that possible?

[Pavel Feldman]

(In reply to comment #6)
> This is definitely an improvement, but it seems to me that we'd want to output an object in the same way we do with Elements so that you can inspect the attribute object. Is that possible?

I am not sure I understand the request. Could you clarify?

[Joseph Pecoraro]

(In reply to comment #6)
> This is definitely an improvement, but it seems to me that we'd want to output
> an object in the same way we do with Elements so that you can inspect the
> attribute object. Is that possible?

What more is there to inspect? The name / value are the important parts. Is
there some more data we are missing?

Also, if you do want to view everything use dir(). That will force a listing as
an object tree, allowing you to see all properties / values / prototype chain.

[Ojan Vafai]

Ugh. Nevermind me. I just wasn't thinking straight.

[Joseph Pecoraro]

Committed r66282
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	LayoutTests/inspector/console-format-expected.txt
	M	LayoutTests/inspector/console-format.html
	M	LayoutTests/ChangeLog
r66282 = 67e7198a50637082bdc125592905a4afb8fdb9d1 (refs/remotes/trunk)
http://trac.webkit.org/changeset/66282