Adopt more uses OwnPtr/OwnArray in WebKit2
Created attachment 65636 [details] Patch
Attachment 65636 [details] did not build on qt: Build output: http://queues.webkit.org/results/3808087
Comment on attachment 65636 [details] Patch > - for (size_t i = 0; i < m_size; ++i) > - m_entries[i]->ref(); You got rid of the ref() here. That is not right, is it? Should this be an array of RefPtr<APIObject>? r=me as long as you fix that ref thing
(In reply to comment #3) > (From update of attachment 65636 [details]) > > - for (size_t i = 0; i < m_size; ++i) > > - m_entries[i]->ref(); > > You got rid of the ref() here. That is not right, is it? It is. I commented in the changelog that I change the semantics of this function to match the adopt function. It is currently unused. > Should this be an array of RefPtr<APIObject>? It can't be if we want to allow the adoption semantics to remain the same (the C API is allowed to give a buffer that is adopted by the Array).
Landed in r66165.