Bug 44728 – Adopt more uses OwnPtr/OwnArray in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Adopt more uses OwnPtr/OwnArray in WebKit2

[Sam Weinig]

Created attachment 65636 [details]
Patch

[Early Warning System Bot]

Attachment 65636 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3808087

[Darin Adler]

Comment on attachment 65636 [details]
Patch

> -    for (size_t i = 0; i < m_size; ++i)
> -        m_entries[i]->ref();

You got rid of the ref() here. That is not right, is it?

Should this be an array of RefPtr<APIObject>?

r=me as long as you fix that ref thing

[Sam Weinig]

(In reply to comment #3)
> (From update of attachment 65636 [details])
> > -    for (size_t i = 0; i < m_size; ++i)
> > -        m_entries[i]->ref();
> 
> You got rid of the ref() here. That is not right, is it?

It is.  I commented in the changelog that I change the semantics of this function to match the adopt function. It is currently unused.

> Should this be an array of RefPtr<APIObject>?

It can't be if we want to allow the adoption semantics to remain the same (the C API is allowed to give a buffer that is adopted by the Array).

[Sam Weinig]

Landed in r66165.