RESOLVED FIXED Bug 44727
[chromium] Add support for non-text/non-URL types in event.dataTransfer 
https://bugs.webkit.org/show_bug.cgi?id=44727
Summary [chromium] Add support for non-text/non-URL types in event.dataTransfer
Daniel Cheng
Reported 2010-08-26 15:47:18 PDT
Created attachment 65634 [details] Preliminary patch for reference This is the WebKit patch to add that support. http://crbug.com/31037 is for the Chromium changes. I'm currently uncertain of how to split up the change nicely; right now, it requires a simultaneous commit against the WebKit and Chromium repositories.
Attachments
Preliminary patch for reference (72.10 KB, patch)
2010-08-26 15:47 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (79.26 KB, patch)
2010-08-30 16:26 PDT, Daniel Cheng 		tony: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2010-08-30 16:26:12 PDT
Created attachment 65977 [details] Patch
Daniel Cheng
Comment 2 2010-08-30 16:30:25 PDT
The associated Chromium-side patch is at http://codereview.chromium.org/2868069/show. The Windows side for the Chromium patch is more or less complete (ClipboardWin::WriteData does need to be updated though). I am working on merging in the changes I've made to the Mac/Linux side. I'm currently not sure how to land this patch once it gets past review; there's some dependencies from the browser on renderer side changes, and vise versa. There's also what (I suspect) is a layering violation in the EventSender/WebViewHost changes, so any suggestions on how to resolve that would be welcome.
Tony Chang
Comment 3 2010-08-30 17:25:12 PDT
Comment on attachment 65977 [details] Patch dcheng and I discussed various ways to break this patch into smaller pieces. r- for now, since this is pretty much unreviewable and not landable anyway (it would break chromium since it's an api change).
Ryosuke Niwa
Comment 4 2012-05-01 23:15:52 PDT
Does this bug still exist?
Daniel Cheng
Comment 5 2012-05-02 11:51:46 PDT
The various bits that this involves have landed and been in tree for some time now.
Ryosuke Niwa
Comment 6 2012-05-02 21:54:10 PDT
Excellent!
Note You need to log in before you can comment on or make changes to this bug.