WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44726
WebFrameProxies aren't destroyed until a page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=44726
Summary
WebFrameProxies aren't destroyed until a page is destroyed
Alexey Proskuryakov
Reported
2010-08-26 15:35:12 PDT
There is no code that would destroy WebFrameProxies earlier than the page they were created in goes away. <
rdar://problem/8359858
>
Attachments
proposed patch
(24.50 KB, patch)
2010-08-26 15:41 PDT
,
Alexey Proskuryakov
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2010-08-26 15:41:39 PDT
Created
attachment 65633
[details]
proposed patch
Sam Weinig
Comment 2
2010-08-26 15:52:51 PDT
Comment on
attachment 65633
[details]
proposed patch Nice. I was kind of assuming we were going to use the detachFromParent FrameLoaderClient functions, but I like this approach. Are we going to need/want a way to signal that a Frame has changed Pages in the WebKit2 API? r=me
Alexey Proskuryakov
Comment 3
2010-08-26 16:02:00 PDT
> Are we going to need/want a way to signal that a Frame has changed Pages in the WebKit2 API?
I don't know, but there is a special FrameLoaderClient call for changing documents, which we need to implement anyway - didTransferChildFrameToNewDocument().
Alexey Proskuryakov
Comment 4
2010-08-26 16:04:04 PDT
Committed <
http://trac.webkit.org/changeset/66146
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug