Bug 44724 - [Chromium] Implement LayoutTestController::markerTextForListItem()
Summary: [Chromium] Implement LayoutTestController::markerTextForListItem()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 15:14 PDT by Dumitru Daniliuc
Modified: 2010-08-26 21:34 PDT (History)
5 users (show)

See Also:

Attachments
patch (5.38 KB, patch)
2010-08-26 16:14 PDT, Dumitru Daniliuc 		fishd: review-
dumi: commit-queue-
Details | Formatted Diff | Diff
patch (5.32 KB, patch)
2010-08-26 17:13 PDT, Dumitru Daniliuc 		fishd: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-08-26 15:14:08 PDT 
Add markerTextForListItem() to Chromium's LayoutTestController.
Comment 1 Dumitru Daniliuc 2010-08-26 16:14:39 PDT 
Created attachment 65641 [details]
patch

WebKit's side of the patch. Chromium's side is at http://codereview.chromium.org/3213001.
Comment 2 Darin Fisher (:fishd, Google) 2010-08-26 16:49:08 PDT 
Comment on attachment 65641 [details]
patch

WebKit/chromium/public/WebFrame.h:522
 +      virtual WebString markerTextForListItem(const WebElement& webElement) const = 0;
nit: no parameter name here since the parameter name does not add information.

WebKit/chromium/src/WebFrameImpl.cpp:1696
 +      return WebCore::markerTextForListItem(element.get());
nit: change this to the following:

WebString WebFrameImpl::markerTextForListItem(const WebElement& element) const
{
    return WebCore::markerTextForListItem(element.unwrap<Element>());
}
Comment 3 Dumitru Daniliuc 2010-08-26 17:13:52 PDT 
Created attachment 65648 [details]
patch
Comment 4 WebKit Review Bot 2010-08-26 19:23:30 PDT 
Attachment 65648 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3865003
Comment 5 Darin Fisher (:fishd, Google) 2010-08-26 20:33:31 PDT 
Comment on attachment 65648 [details]
patch

WebKit/chromium/src/WebFrameImpl.h:179
 +      virtual WebString markerTextForListItem(const WebElement& webElement) const;
nit: no parameter name here.

R=me w/ that fix
Comment 6 Dumitru Daniliuc 2010-08-26 20:37:12 PDT 
(In reply to comment #5)
> (From update of attachment 65648 [details])
> WebKit/chromium/src/WebFrameImpl.h:179
>  +      virtual WebString markerTextForListItem(const WebElement& webElement) const;
> nit: no parameter name here.
> 
> R=me w/ that fix

done.
Comment 7 WebKit Review Bot 2010-08-26 21:08:28 PDT 
http://trac.webkit.org/changeset/66176 might have broken Chromium Linux Release
Comment 8 Dumitru Daniliuc 2010-08-26 21:34:35 PDT 
landed: r66176. fixed the build breakage in r66180.