Bug 44720 - Remove unnecessary AlphaBlend in PasteboardWin
Summary: Remove unnecessary AlphaBlend in PasteboardWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 14:47 PDT by Patrick R. Gansterer
Modified: 2010-08-27 18:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2010-08-26 14:52 PDT, Patrick R. Gansterer 		aroben: review-
aroben: commit-queue-
Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2010-08-26 15:00 PDT, Patrick R. Gansterer 		aroben: review-
aroben: commit-queue-
Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2010-08-26 15:04 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-08-26 14:47:49 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-08-26 14:52:18 PDT 
Created attachment 65621 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-08-26 14:55:12 PDT 
Comment on attachment 65621 [details]
Patch

I think it would be good to mention in the ChangeLog that testing showed that alpha never survives copy-and-paste on Windows in any browser, and that StretchBlt was overkill since the source and destination size were always equal. Other than that this looks great!
Comment 3 Patrick R. Gansterer 2010-08-26 15:00:32 PDT 
Created attachment 65623 [details]
Patch
Comment 4 Adam Roben (:aroben) 2010-08-26 15:01:54 PDT 
Comment on attachment 65623 [details]
Patch

> +        Replacing AlphaBlend with BitBlt is save because testing showed that alpha

Typo: save (should be "safe")

> +        never survives copy-and-paste on Windows in any browser, and StretchBlt 
> +        was a overkill since the source and destination size are always equal.

Typo: a overkill (should be "overkill")

Soooo close!
Comment 5 Patrick R. Gansterer 2010-08-26 15:04:43 PDT 
Created attachment 65624 [details]
Patch
Comment 6 Adam Roben (:aroben) 2010-08-26 15:05:48 PDT 
Comment on attachment 65624 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2010-08-27 18:59:17 PDT 
Comment on attachment 65624 [details]
Patch

Clearing flags on attachment: 65624

Committed r66291: <http://trac.webkit.org/changeset/66291>
Comment 8 WebKit Commit Bot 2010-08-27 18:59:22 PDT 
All reviewed patches have been landed.  Closing bug.