Bug 44708 - [chromium] WebEntities is broken
Summary: [chromium] WebEntities is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 12:47 PDT by Ryosuke Niwa
Modified: 2010-08-26 13:54 PDT (History)
4 users (show)

See Also:


Attachments
fixes the bug (3.03 KB, patch)
2010-08-26 13:01 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-08-26 12:47:48 PDT
After new HTML tree builder has been enabled, /WebKit/chromium/src/WebEntities.* got broken and Chromium's "Save As" do not function as intended.  http://crbug.com/53148/
Comment 1 Ryosuke Niwa 2010-08-26 13:01:10 PDT
Created attachment 65604 [details]
fixes the bug
Comment 2 Eric Seidel (no email) 2010-08-26 13:11:39 PDT
Comment on attachment 65604 [details]
fixes the bug

Yay!  It no longer needs to include the HTMLEntityTable.h header though.
Comment 3 James Robinson 2010-08-26 13:12:26 PDT
Do we really have to keep the 0x0027->#39 mapping?  What's actually testing that?
Comment 4 Ryosuke Niwa 2010-08-26 13:46:24 PDT
(In reply to comment #3)
> Do we really have to keep the 0x0027->#39 mapping?  What's actually testing that?

I could fix the test to expect ' but I didn't want to modify that now because it might trigger some incompatibility issues.
Comment 5 Ryosuke Niwa 2010-08-26 13:49:37 PDT
(In reply to comment #2)
> (From update of attachment 65604 [details])
> Yay!  It no longer needs to include the HTMLEntityTable.h header though.

Will remove and commit.
Comment 6 Ryosuke Niwa 2010-08-26 13:54:35 PDT
Committed r66131: <http://trac.webkit.org/changeset/66131>