Bug 44693 - [WINCE] Port SoftLinking to WinCE
Summary: [WINCE] Port SoftLinking to WinCE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 09:30 PDT by Patrick R. Gansterer
Modified: 2010-08-27 17:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2010-08-26 13:50 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue-
Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2010-08-26 14:46 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-08-26 09:30:35 PDT 
WinCE provides GetProcAddressW and GetProcAddressA for softlinking.
Unfortunately WinNT provides only GetProcAddress (without A or W).
Comment 1 Patrick R. Gansterer 2010-08-26 13:50:16 PDT 
Created attachment 65614 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-26 13:51:18 PDT 
Attachment 65614 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/win/SoftLinking.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-08-26 14:24:20 PDT 
Comment on attachment 65614 [details]
Patch

> +        Add a platformdependent macro for GetProcAddress.

Typo: platformdependent

> +#if OS(WINCE)
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddressW(library##Library(), L###functionName)
> +#else
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddress(library##Library(), #functionName)
> +#endif

Should we use GetProcAddressA on WinCE? GetProcAddress on NT is ANSI-only IIRC.

r+ since the code looks fine, but you should consider the above.
Comment 4 Patrick R. Gansterer 2010-08-26 14:46:39 PDT 
Created attachment 65620 [details]
Patch
Comment 5 WebKit Review Bot 2010-08-26 14:48:50 PDT 
Attachment 65620 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/win/SoftLinking.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Adam Roben (:aroben) 2010-08-26 14:55:26 PDT 
Comment on attachment 65620 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2010-08-27 17:55:24 PDT 
Comment on attachment 65620 [details]
Patch

Clearing flags on attachment: 65620

Committed r66286: <http://trac.webkit.org/changeset/66286>
Comment 8 WebKit Commit Bot 2010-08-27 17:55:28 PDT 
All reviewed patches have been landed.  Closing bug.