Bug 44693 – [WINCE] Port SoftLinking to WinCE

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

WinCE provides GetProcAddressW and GetProcAddressA for softlinking.
Unfortunately WinNT provides only GetProcAddress (without A or W).

[Patrick R. Gansterer]

Created attachment 65614 [details]
Patch

[WebKit Review Bot]

Attachment 65614 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/win/SoftLinking.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 65614 [details]
Patch

> +        Add a platformdependent macro for GetProcAddress.

Typo: platformdependent

> +#if OS(WINCE)
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddressW(library##Library(), L###functionName)
> +#else
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName) GetProcAddress(library##Library(), #functionName)
> +#endif

Should we use GetProcAddressA on WinCE? GetProcAddress on NT is ANSI-only IIRC.

r+ since the code looks fine, but you should consider the above.

[Patrick R. Gansterer]

Created attachment 65620 [details]
Patch

[WebKit Review Bot]

Attachment 65620 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/win/SoftLinking.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 65620 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 65620 [details]
Patch

Clearing flags on attachment: 65620

Committed r66286: <http://trac.webkit.org/changeset/66286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.