Bug 44687 - Web Inspector: use context menu items with checkbox for DOM breakpoints
Summary: Web Inspector: use context menu items with checkbox for DOM breakpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 08:25 PDT by Pavel Podivilov
Modified: 2010-08-27 06:39 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch. (4.61 KB, patch)
2010-08-26 08:29 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Proposed patch. (5.50 KB, patch)
2010-08-26 08:48 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Proposed patch. (5.75 KB, patch)
2010-08-26 08:49 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Proposed patch. (5.72 KB, patch)
2010-08-26 08:53 PDT, Pavel Podivilov 		pfeldman: review-
Details | Formatted Diff | Diff
Proposed patch. (7.66 KB, patch)
2010-08-26 09:14 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-08-26 08:25:22 PDT 
Web Inspector: use context menu items with checkbox for setting and removing DOM breakpoints
Comment 1 Pavel Podivilov 2010-08-26 08:29:19 PDT 
Created attachment 65568 [details]
Proposed patch.
Comment 2 Pavel Podivilov 2010-08-26 08:48:44 PDT 
Created attachment 65570 [details]
Proposed patch.
Comment 3 Pavel Podivilov 2010-08-26 08:49:29 PDT 
Created attachment 65571 [details]
Proposed patch.
Comment 4 Pavel Podivilov 2010-08-26 08:53:38 PDT 
Created attachment 65572 [details]
Proposed patch.
Comment 5 Pavel Feldman 2010-08-26 08:57:15 PDT 
Comment on attachment 65572 [details]
Proposed patch.

WebCore/inspector/front-end/DOMAgent.js:743
 +  WebInspector.DOMBreakpoint.ContextMenuLabels = {};
This slows down our load time, please do it lazily.
Comment 6 Pavel Podivilov 2010-08-26 09:14:55 PDT 
Created attachment 65574 [details]
Proposed patch.
Comment 7 Pavel Feldman 2010-08-27 06:39:10 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/BreakpointsSidebarPane.js
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/inspector.js
Committed r66213