GLES2Canvas currently contains all the shaders for 2D <canvas>. They should be refactored out into their own class hierarchy.
Created attachment 65555 [details] Patch
Comment on attachment 65555 [details] Patch This refactoring looks good overall but I'm concerned about putting a name as generic as Shader into the WebCore namespace. I will start sending out patches today which introduce a gpu2d sub-namespace into which I'm also planning to put some shader-related classes that will need to be merged with your work. Once that is in place I think it would be best to scope Shader (and the other accelerated 2D canvas classes) within that namespace. I wonder whether you can hold off this commit for a day or two. If not, I'll r+ it and we can refactor things later. Up to you.
(In reply to comment #2) > (From update of attachment 65555 [details]) > This refactoring looks good overall but I'm concerned about putting a name as generic as Shader into the WebCore namespace. I will start sending out patches today which introduce a gpu2d sub-namespace into which I'm also planning to put some shader-related classes that will need to be merged with your work. Once that is in place I think it would be best to scope Shader (and the other accelerated 2D canvas classes) within that namespace. I wonder whether you can hold off this commit for a day or two. If not, I'll r+ it and we can refactor things later. Up to you. According to the EWS bots, it doesn't seem to conflict with anything yet. I don't mind refactoring after your stuff goes in, as long as this change doesn't slow you down too much.
Comment on attachment 65555 [details] Patch r+'ing after offline discussion.
Committed r66130: <http://trac.webkit.org/changeset/66130>
http://trac.webkit.org/changeset/66130 might have broken Chromium Mac Release