Bug 44680 - Web Inspector: InspectorValue accessors for Boolean type should have Boolean suffix
Summary: Web Inspector: InspectorValue accessors for Boolean type should have Boolean ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 05:47 PDT by Ilya Tikhonovsky
Modified: 2010-08-26 06:12 PDT (History)
8 users (show)

See Also:

Attachments
[patch] initial version. (21.92 KB, patch)
2010-08-26 05:57 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-08-26 05:47:27 PDT 
It would be better to rename setBool, pushBool and asBool to setBoolean, pushBoolean and asBoolean for better matching with the results of JS typeof operator.
Comment 1 Ilya Tikhonovsky 2010-08-26 05:57:55 PDT 
Created attachment 65551 [details]
[patch] initial version.
Comment 2 Ilya Tikhonovsky 2010-08-26 06:12:07 PDT 
Committed r66098
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptProfile.cpp
	M	WebCore/bindings/v8/ScriptProfile.cpp
	M	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/InspectorDOMStorageResource.cpp
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorResource.cpp
	M	WebCore/inspector/InspectorValues.h
	M	WebCore/inspector/ScriptBreakpoint.cpp
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorValues.cpp
	M	WebCore/inspector/TimelineRecordFactory.cpp
r66098 = ec5ebeb76b2656ed530de24ad25778299f38879c (refs/remotes/trunk)