Bug 44674 - [Qt] tst_QWebFrame::popupFocus() hardcode the element position
Summary: [Qt] tst_QWebFrame::popupFocus() hardcode the element position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 44675
  Show dependency tree / graph
 
Reported: 2010-08-26 04:14 PDT by Benjamin Poulain
Modified: 2010-08-26 08:48 PDT (History)
2 users (show)

See Also:

Attachments
Fix the issue on Meego (1.43 KB, patch)
2010-08-26 04:18 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-08-26 04:14:36 PDT 
The test tst_QWebFrame::popupFocus() assume the position (25, 25) is inside the combo box. This is not true depending on the style, and the test fails on Meego.
Comment 1 Benjamin Poulain 2010-08-26 04:18:29 PDT 
Created attachment 65544 [details]
Fix the issue on Meego

This patch dynamically find the position of the combo element instead of hardcoding a position to click.
Comment 2 WebKit Commit Bot 2010-08-26 05:07:05 PDT 
Comment on attachment 65544 [details]
Fix the issue on Meego

Clearing flags on attachment: 65544

Committed r66096: <http://trac.webkit.org/changeset/66096>
Comment 3 WebKit Commit Bot 2010-08-26 05:07:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2010-08-26 08:48:36 PDT 
Revision r66096 cherry-picked into qtwebkit-2.1 with commit 5019f1f94fcf1b367ce7396acf36890a9f91c5b0