Bug 44673 - Web Inspector: scripts are pushed to front-end before resources
Summary: Web Inspector: scripts are pushed to front-end before resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 03:15 PDT by Pavel Podivilov
Modified: 2010-08-26 04:34 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch. (2.87 KB, patch)
2010-08-26 03:29 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Proposed patch. (2.87 KB, patch)
2010-08-26 03:42 PDT, Pavel Podivilov 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-08-26 03:15:57 PDT 
Web Inspector: scripts are pushed to front-end before resources
Comment 1 Pavel Podivilov 2010-08-26 03:29:55 PDT 
Created attachment 65539 [details]
Proposed patch.
Comment 2 WebKit Review Bot 2010-08-26 03:34:21 PDT 
Attachment 65539 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorController.cpp:665:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Podivilov 2010-08-26 03:42:03 PDT 
Created attachment 65541 [details]
Proposed patch.
Comment 4 Pavel Feldman 2010-08-26 03:56:07 PDT 
Comment on attachment 65541 [details]
Proposed patch.

Clearing flags on attachment: 65541

Committed r66094: <http://trac.webkit.org/changeset/66094>
Comment 5 Pavel Feldman 2010-08-26 03:56:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2010-08-26 04:30:07 PDT 
Comment on attachment 65541 [details]
Proposed patch.

Rejecting patch 65541 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65541, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
cgi?id=65541&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=44673&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 65541 from bug 44673.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 WebKit Review Bot 2010-08-26 04:34:41 PDT 
http://trac.webkit.org/changeset/66094 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/66093
http://trac.webkit.org/changeset/66094