RESOLVED WORKSFORME 44667
check-webkit-style: test_expectation checker warns about new tests 
https://bugs.webkit.org/show_bug.cgi?id=44667
Summary check-webkit-style: test_expectation checker warns about new tests
Kent Tamura
Reported 2010-08-25 23:34:04 PDT
If a patch add new tests and expectation lines for them, check-webkit-style produces an error like the following (suppose splling-contenteditable.html will be added by a patch): LayoutTests/platform/chromium/test_expectations.txt:3180: Path does not exist. editing/spelling/spelling-contenteditable.html [test/expectations] [2] See https://bugs.webkit.org/show_bug.cgi?id=41832
Attachments
Patch V0 (13.42 KB, patch)
2010-08-26 19:37 PDT, Kenichi Ishibashi 		hamaji: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2010-08-26 19:37:08 PDT
Created attachment 65662 [details] Patch V0
Shinichiro Hamaji
Comment 2 2010-08-26 21:36:59 PDT
Thanks for trying to fix this issue! However, as I wrote in Bug 41832, I think this is not a false-positive but a real warning. We might not need to "fix" this issue. By the way, I've looked at your patch and had a thought. I think we should avoid **kwargs if possible. This feature is unsafe because it allows a typo. For example, it's difficult to find a bug in checker.process_file("file/path", 42, added_file=["added/file"]) (added_file should be added_file*s*). I know **kwargs is useful for certain purpose, but in this case, I guess we don't need it.
Kenichi Ishibashi
Comment 3 2010-08-26 21:53:11 PDT
It's good news for me the warning is not a false-positive:-) And I'm grateful to you for your suggestion about using kwargs. Thank you!
Note You need to log in before you can comment on or make changes to this bug.