Bug 44646 - test conversion: editing/style/typing-style-003.html should use runDumpAsTextEditingTest instead of runEditingTest
Summary: test conversion: editing/style/typing-style-003.html should use runDumpAsText...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Blocker
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 44560
  Show dependency treegraph
 
Reported: 2010-08-25 16:19 PDT by Ryosuke Niwa
Modified: 2010-08-25 18:52 PDT (History)
6 users (show)

See Also:


Attachments
converts the test (42.42 KB, patch)
2010-08-25 16:30 PDT, Ryosuke Niwa
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-08-25 16:19:29 PDT
editing/style/typing-style-003.html is testing the behavior of typing style but we cannot see whether or not correct sequence of DOM modifications are done with runEditingTest.  Furthermore, we don't have to test the correctness of rendering at all.  We should call runDumpAsTextEditingTest instead so that we can test each DOM modification step.
Comment 1 Ryosuke Niwa 2010-08-25 16:30:38 PDT
Created attachment 65496 [details]
converts the test
Comment 2 Ryosuke Niwa 2010-08-25 16:56:04 PDT
Committed r66056: <http://trac.webkit.org/changeset/66056>
Comment 3 WebKit Review Bot 2010-08-25 18:52:29 PDT
http://trac.webkit.org/changeset/66056 might have broken GTK Linux 32-bit Release and GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/66056
http://trac.webkit.org/changeset/66057
http://trac.webkit.org/changeset/66058
http://trac.webkit.org/changeset/66060
http://trac.webkit.org/changeset/66053