RESOLVED FIXED 44627
Add PassOwnArrayPtr 
https://bugs.webkit.org/show_bug.cgi?id=44627
Summary Add PassOwnArrayPtr
Sam Weinig
Reported 2010-08-25 11:20:09 PDT
Add a PassOwnArrayPtr class that does for OwnArrayPtr what PassOwnPtr does for OwnPtr.
Attachments
Patch (24.65 KB, patch)
2010-08-25 11:22 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-08-25 11:22:27 PDT
Created attachment 65447 [details] Patch
Adam Barth
Comment 2 2010-08-25 11:24:26 PDT
Comment on attachment 65447 [details] Patch Do we want an analog to adoptPtr?
WebKit Review Bot
Comment 3 2010-08-25 11:25:28 PDT
Attachment 65447 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/OwnArrayPtr.h:25: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/wtf/OwnArrayPtr.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/wtf/OwnArrayPtrCommon.h:26: #ifndef header guard has wrong style, please use: OwnArrayPtrCommon_h [build/header_guard] [5] JavaScriptCore/wtf/OwnArrayPtrCommon.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/wtf/PassOwnArrayPtr.h:26: #ifndef header guard has wrong style, please use: PassOwnArrayPtr_h [build/header_guard] [5] JavaScriptCore/wtf/PassOwnArrayPtr.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 6 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4 2010-08-25 11:45:12 PDT
(In reply to comment #2) > (From update of attachment 65447 [details]) > Do we want an analog to adoptPtr? The patch adds adoptArrayPtr.
Early Warning System Bot
Comment 5 2010-08-25 11:53:08 PDT
Attachment 65447 [details] did not build on qt: Build output: http://queues.webkit.org/results/3800284
Darin Adler
Comment 6 2010-08-25 15:53:30 PDT
Sam, you should probably fix the style complaints and the Qt breakage.
Sam Weinig
Comment 7 2010-08-26 14:38:43 PDT
Landed in r66139.
Note You need to log in before you can comment on or make changes to this bug.