Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
Created attachment 65446 [details] Patch
Comment on attachment 65446 [details] Patch Well, this is an improvement. There's still more work that needs to be done here, like adding tests and validating the list. WebCore/ChangeLog:8 + Sterilization is covered by a bunch of tests. innerHTML behavior is sadly not. Sterilization ?
Created attachment 65448 [details] Patch for landing
Attachment 65446 [details] did not build on qt: Build output: http://queues.webkit.org/results/3769690
Created attachment 65450 [details] Patch for landing
Holy layering violations, Batman! That Qt code is so wrong is hurts.
(In reply to comment #6) > Holy layering violations, Batman! That Qt code is so wrong is hurts. ;-) It seems that our TODO list just keeps growing!
Comment on attachment 65450 [details] Patch for landing Rejecting patch 65450 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20923 test cases. animations/combo-transform-translate+scale.html -> failed Exiting early after 1 failures. 98 tests run. 41.40s total testing time 97 test cases (98%) succeeded 1 test case (1%) had incorrect layout Full output: http://queues.webkit.org/results/3705632
Comment on attachment 65450 [details] Patch for landing Clearing flags on attachment: 65450 Committed r66057: <http://trac.webkit.org/changeset/66057>
All reviewed patches have been landed. Closing bug.
Committed r66062: <http://trac.webkit.org/changeset/66062>
http://trac.webkit.org/changeset/66057 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/66056 http://trac.webkit.org/changeset/66057 http://trac.webkit.org/changeset/66058 http://trac.webkit.org/changeset/66060 http://trac.webkit.org/changeset/66053
From the ChangeLog - "This is just moving code and should have no functional change" There was a somewhat massive functional change to HTMLElement::deprecatedCreateContextualFragment(), HTMLElement::setInnerText(), and HTMLElement::setOuterText() that broke a few real world sites. I'll file a followup bug with a test case.
(In reply to comment #13) > From the ChangeLog - "This is just moving code and should have no functional change" > > There was a somewhat massive functional change to HTMLElement::deprecatedCreateContextualFragment(), HTMLElement::setInnerText(), and HTMLElement::setOuterText() that broke a few real world sites. > > I'll file a followup bug with a test case. Thanks! If you post a bug and test I'll be happy to take a look.
(In reply to comment #14) > (In reply to comment #13) > > From the ChangeLog - "This is just moving code and should have no functional change" > > > > There was a somewhat massive functional change to HTMLElement::deprecatedCreateContextualFragment(), HTMLElement::setInnerText(), and HTMLElement::setOuterText() that broke a few real world sites. > > > > I'll file a followup bug with a test case. > > Thanks! If you post a bug and test I'll be happy to take a look. Yup, CC'ed you on https://bugs.webkit.org/show_bug.cgi?id=55229