Bug 44619 - drawGDIGlyphs checks if the offset is empty incorrectly causing problems with the shadow
Summary: drawGDIGlyphs checks if the offset is empty incorrectly causing problems with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 10:15 PDT by Alejandro G. Castro
Modified: 2010-08-27 02:23 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.25 KB, patch)
2010-08-26 01:39 PDT, Alejandro G. Castro 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2010-08-25 10:15:35 PDT 
From the comment:

https://bugs.webkit.org/show_bug.cgi?id=44603#c5

(In reply to comment #2)
> After changing the names I've realized that this condition could be wrong but the old name could make it seem correct:
> 
> +            drawIntoBitmap = !offset.isEmpty() || blur;
> 
> It is in this file: WebCore/platform/graphics/win/FontCGWin.cpp static void drawGDIGlyphs
> 
> Could someone check if in Windows negative offsets of the text actually work, or no offsets but blurring. We could open a new bug in this case.

I’ve asked someone to check, and indeed in <data:text/html,%3Cdiv%20style=%22-webkit-font-smoothing:%20none%22%3E%3Cdiv%20style=%22text-shadow:%202px%202px%20red%22%3Etest%3C/div%3E%3Cdiv%20style=%22text-shadow:%20-2px%20-2px%20red%22%3Etest%3C/div%3E%3C/div%3E> the bottom line is missing the shadow. Good catch!
Comment 1 Alejandro G. Castro 2010-08-26 01:39:06 PDT 
Created attachment 65534 [details]
Proposed patch

I can not test the patch but I guess at least it can be used as a initial point.
Comment 2 Alejandro G. Castro 2010-08-27 02:23:35 PDT 
landed r66192, closing bug