Bug 44617 - Web Inspector: explicit callId argument can be removed from the functions signatures declared in Inspector.idl
Summary: Web Inspector: explicit callId argument can be removed from the functions sig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 09:26 PDT by Ilya Tikhonovsky
Modified: 2010-08-26 01:31 PDT (History)
8 users (show)

See Also:

Attachments
[patch] initial version. (43.63 KB, patch)
2010-08-25 12:43 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-08-25 09:26:38 PDT 
as far as each call from inspector front-end to inspector back-end has its own seq property by default we can remove explicit callId arguments from all backend functions.
And now it is possible to call any InspectorBackend function with a callback as additional argument.

as example
InspectorBackend.enableResourceTracking();

or

InspectorBackend.enableResourceTracking(someCallbackFunction);
Comment 1 Ilya Tikhonovsky 2010-08-25 12:43:37 PDT 
Created attachment 65462 [details]
[patch] initial version.
Comment 2 Pavel Feldman 2010-08-25 13:30:27 PDT 
Comment on attachment 65462 [details]
[patch] initial version.

WebCore/inspector/CodeGeneratorInspector.pm:357
 +      push(@function, "        responseMessage->setString(\"type\", \"response\");");
Why do we specify type for something that has seq?

WebCore/inspector/CodeGeneratorInspector.pm: 
 +          reportProtocolError(callId, "dispatch", "Error: Invalid message format. The type of 'command' property should be string.");
I think this is time to write a test that would issue valid and invalid requests against InspectorBackend and test the response.

WebCore/inspector/front-end/CSSStyleModel.js:94
 +          InspectorBackend.setStyleText(styleId, cssText);
Is this case handled properly? A test would be great.
Comment 3 Ilya Tikhonovsky 2010-08-26 01:31:17 PDT 
Committed r66087
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/ProfilerAgent.js
	M	WebCore/ChangeLog
	M	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/front-end/MetricsSidebarPane.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ProfileView.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/CSSStyleModel.js
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/ScriptView.js
	M	WebCore/inspector/front-end/ProfilesPanel.js
	M	WebCore/inspector/front-end/DOMStorage.js
	M	WebCore/inspector/front-end/Database.js
	M	WebCore/inspector/front-end/AuditRules.js
	M	WebCore/inspector/front-end/BreakpointManager.js
	M	WebCore/inspector/front-end/InjectedScriptAccess.js
	M	LayoutTests/http/tests/inspector/inspect-iframe-from-different-domain.html
	M	LayoutTests/inspector/styles-source-offsets.html
	M	LayoutTests/inspector/elements-panel-search.html
	M	LayoutTests/inspector/styles-iframe.html
	M	LayoutTests/inspector/styles-source-lines.html
	M	LayoutTests/ChangeLog
r66087 = dbd6bd336843e7a0ebbf6b16a6682700ebd6f782 (refs/remotes/trunk)