Bug 44616 - text-shadow is not respected in RenderSVGText::repaintRectInLocalCoordinates()
Summary: text-shadow is not respected in RenderSVGText::repaintRectInLocalCoordinates()
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2010-08-25 09:26 PDT by Nikolas Zimmermann
Modified: 2010-08-26 04:34 PDT (History)
4 users (show)

See Also:

Patch (180.33 KB, patch)
2010-08-26 03:04 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-08-25 09:26:09 PDT
CSS transition + text-shadow highlights repaint bugs, as the text-shadow is not respected in RenderSVGText::repaintRectInLocalCoordinates().
Fix that, and also cleanup the code (FIXME in SVGRenderStyle) -> move the inflateForShadow() function in ShadowData.
Comment 1 Nikolas Zimmermann 2010-08-26 03:04:16 PDT
Created attachment 65538 [details]
Comment 2 WebKit Review Bot 2010-08-26 03:07:13 PDT
Attachment 65538 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/style/ShadowData.cpp:28:  Use 'using namespace std;' instead of 'using std::min;'.  [build/using_std] [4]
WebCore/rendering/style/ShadowData.cpp:29:  Use 'using namespace std;' instead of 'using std::max;'.  [build/using_std] [4]
Total errors found: 2 in 16 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dirk Schulze 2010-08-26 03:23:04 PDT
Comment on attachment 65538 [details]

r=me with fixed style errors from style bot.
Comment 4 Nikolas Zimmermann 2010-08-26 03:28:12 PDT
Landed in r66093.
Comment 5 WebKit Review Bot 2010-08-26 04:34:35 PDT
http://trac.webkit.org/changeset/66093 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list: