Bug 44612 - Web Inspector: support checked and disabled context menu items.
Summary: Web Inspector: support checked and disabled context menu items.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 08:30 PDT by Pavel Feldman
Modified: 2010-08-25 09:56 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed fix. (1.18 KB, patch)
2010-08-25 08:34 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-25 08:30:56 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2010-08-25 08:34:22 PDT 
Created attachment 65421 [details]
[PATCH] Proposed fix.
Comment 2 Yury Semikhatsky 2010-08-25 08:38:54 PDT 
Comment on attachment 65421 [details]
[PATCH] Proposed fix.

WebCore/platform/ContextMenu.cpp:825
 +      if (ContextMenuItemBaseCustomTag <= item.action() && item.action() <= ContextMenuItemLastCustomTag)
Please move this above the switch.
Comment 3 Pavel Feldman 2010-08-25 08:49:14 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/ContextMenu.cpp
Committed r66015
Comment 4 Joseph Pecoraro 2010-08-25 09:56:00 PDT 
> WebCore/platform/ContextMenu.cpp:825
>  +      if (ContextMenuItemBaseCustomTag <= item.action() && item.action() <= ContextMenuItemLastCustomTag)
> Please move this above the switch.

Yury's, when you make review comments it would be helpful to also explain
why you made your suggestion. Sometimes it is not obvious to me. Here, with
a little investigation I see that was a very good review comment to prevent
doing unnecessary work before an early return. Thanks!