RESOLVED FIXED 44612
Web Inspector: support checked and disabled context menu items. 
https://bugs.webkit.org/show_bug.cgi?id=44612
Summary Web Inspector: support checked and disabled context menu items.
Pavel Feldman
Reported 2010-08-25 08:30:56 PDT
Patch to follow.
Attachments
[PATCH] Proposed fix. (1.18 KB, patch)
2010-08-25 08:34 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-08-25 08:34:22 PDT
Created attachment 65421 [details] [PATCH] Proposed fix.
Yury Semikhatsky
Comment 2 2010-08-25 08:38:54 PDT
Comment on attachment 65421 [details] [PATCH] Proposed fix. WebCore/platform/ContextMenu.cpp:825 + if (ContextMenuItemBaseCustomTag <= item.action() && item.action() <= ContextMenuItemLastCustomTag) Please move this above the switch.
Pavel Feldman
Comment 3 2010-08-25 08:49:14 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/ContextMenu.cpp Committed r66015
Joseph Pecoraro
Comment 4 2010-08-25 09:56:00 PDT
> WebCore/platform/ContextMenu.cpp:825 > + if (ContextMenuItemBaseCustomTag <= item.action() && item.action() <= ContextMenuItemLastCustomTag) > Please move this above the switch. Yury's, when you make review comments it would be helpful to also explain why you made your suggestion. Sometimes it is not obvious to me. Here, with a little investigation I see that was a very good review comment to prevent doing unnecessary work before an early return. Thanks!
Note You need to log in before you can comment on or make changes to this bug.