Bug 44607 – Web Inspector: lazily request frontend settings instead of pushing them on connect

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: lazily request frontend settings instead of pushing them on connect. This is the first step to having all panels populated lazily. We will need this to keep remote debugging protocol clean so that remote client can request only the data it needs instead of processing tons of them after connecting to the backend.

[Yury Semikhatsky]

Created attachment 65410 [details]
Patch

[Pavel Feldman]

Comment on attachment 65410 [details]
Patch

WebCore/inspector/front-end/ProfilesPanel.js:204
 +          this._requestedProfiles = false;
this._profilesWereRequested;
WebCore/inspector/Inspector.idl:102
 +          [handler=Controller] void populateScriptObjects();
Please comment that it should be further split into the parts.

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 65410 [details])
> WebCore/inspector/front-end/ProfilesPanel.js:204
>  +          this._requestedProfiles = false;
> this._profilesWereRequested;
> WebCore/inspector/Inspector.idl:102
>  +          [handler=Controller] void populateScriptObjects();
> Please comment that it should be further split into the parts.

All done.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/html/HTMLDocument.cpp
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/front-end/ProfilesPanel.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/inspector.js
Committed r66012