Bug 44585 - [DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure
Summary: [DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 22:54 PDT by Kent Tamura
Modified: 2010-08-30 17:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2010-08-24 23:02 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-08-24 22:54:03 PDT 
[DRT/Chromium] Fix fast/notifications/notifications-display-close-events.html failure
Comment 1 Kent Tamura 2010-08-24 23:02:22 PDT 
Created attachment 65374 [details]
Patch
Comment 2 Adam Barth 2010-08-30 16:50:05 PDT 
Comment on attachment 65374 [details]
Patch

> WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50
> +static void deferredDisplayDispatch(WebNotification notification)
> +{
> +    notification.dispatchDisplayEvent();
> +}
We really would like to have RunnableMethods, huh?
Comment 3 Kent Tamura 2010-08-30 17:17:58 PDT 
(In reply to comment #2)
> (From update of attachment 65374 [details])
> > WebKitTools/DumpRenderTree/chromium/NotificationPresenter.cpp:50
> > +static void deferredDisplayDispatch(WebNotification notification)
> > +{
> > +    notification.dispatchDisplayEvent();
> > +}
> We really would like to have RunnableMethods, huh?

Probably.  Anyway, we need to revisit here to remove base/task.h dependency.
Comment 4 Kent Tamura 2010-08-30 17:19:26 PDT 
Comment on attachment 65374 [details]
Patch

Clearing flags on attachment: 65374

Committed r66430: <http://trac.webkit.org/changeset/66430>
Comment 5 Kent Tamura 2010-08-30 17:19:34 PDT 
All reviewed patches have been landed.  Closing bug.