Bug 44578 - new-run-webkit-tests: add additional, miscellaneous unit tests
Summary: new-run-webkit-tests: add additional, miscellaneous unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 19:58 PDT by Dirk Pranke
Modified: 2010-08-25 14:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.11 KB, patch)
2010-08-24 20:01 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-08-24 19:58:27 PDT
new-run-webkit-tests: add more unit tests
Comment 1 Dirk Pranke 2010-08-24 20:01:04 PDT
Created attachment 65364 [details]
Patch
Comment 2 Ojan Vafai 2010-08-25 08:59:23 PDT
Comment on attachment 65364 [details]
Patch

WebKitTools/Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:5
 +  // WONTFIX : failures/expected/image.html = IMAGE
I'd be OK with leaving this in and marking it as PASS. Just leave in the comment above. It at least documents the current behavior and will start failing if something changes.
Comment 3 Dirk Pranke 2010-08-25 13:10:00 PDT
(In reply to comment #2)
> (From update of attachment 65364 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:5
>  +  // WONTFIX : failures/expected/image.html = IMAGE
> I'd be OK with leaving this in and marking it as PASS. Just leave in the comment above. It at least documents the current behavior and will start failing if something changes.

Interesting idea. Also makes sure that marking tests as PASS works :)
Comment 4 Dirk Pranke 2010-08-25 14:45:38 PDT
Committed r66045: <http://trac.webkit.org/changeset/66045>