Bug 44565 - [GTK] WebKitGTK+ needs proper introspection annotation for most types and methods
Summary: [GTK] WebKitGTK+ needs proper introspection annotation for most types and met...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
: 40460 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-24 17:02 PDT by Gustavo Noronha (kov)
Modified: 2014-04-08 18:40 PDT (History)
3 users (show)

See Also:

Attachments
first smallish set of annotations (3.54 KB, patch)
2010-08-24 17:04 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-08-24 17:02:08 PDT 
That's about it. Code such as this makes programs written using Introspection crash:

from gi.repository import WebKit

wv = WebKit.WebView()
settings = wv.get_settings()
settings = wv.get_settings()

Because the introspection information that is generated naively assumes that get_settings returns a new ref, and unrefs it. Assuming ownership and transfer information is just dumb IMO, but not really important for this bug - I'll use this bug to drop many patches implementing proper annotations.
Comment 1 Gustavo Noronha (kov) 2010-08-24 17:04:29 PDT 
Created attachment 65345 [details]
first smallish set of annotations
Comment 2 Martin Robinson 2010-08-25 11:03:59 PDT 
Comment on attachment 65345 [details]
first smallish set of annotations

Great documentation improvements too. LGTM.
Comment 3 Gustavo Noronha (kov) 2010-08-26 06:12:15 PDT 
Comment on attachment 65345 [details]
first smallish set of annotations

Clearing flags on attachment: 65345

Committed r66099: <http://trac.webkit.org/changeset/66099>
Comment 4 Gustavo Noronha (kov) 2010-08-26 06:12:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Gustavo Noronha (kov) 2010-08-26 06:15:54 PDT 
I'll keep this bug open to drop the other patches in it when I'm through with them!
Comment 6 Alan Knowles 2011-02-01 21:36:53 PST 
*** Bug 40460 has been marked as a duplicate of this bug. ***
Comment 7 Martin Robinson 2014-04-08 18:40:20 PDT 
Pretty sure we can close this now.