Bug 44554 - Delete LegacyHTMLTreeBuilder
Summary: Delete LegacyHTMLTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 14:49 PDT by Adam Barth
Modified: 2010-08-24 15:27 PDT (History)
1 user (show)

See Also:

Attachments
Patch (103.56 KB, patch)
2010-08-24 14:50 PDT, Adam Barth 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-24 14:49:26 PDT 
Delete LegacyHTMLTreeBuilder
Comment 1 Adam Barth 2010-08-24 14:50:59 PDT 
Created attachment 65329 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-08-24 14:59:58 PDT 
Comment on attachment 65329 [details]
Patch

WebCore/WebCore.xcodeproj/project.pbxproj: 
 +  		512DD8F50D91E6AF000F89EE /* LegacyWebArchive.h in Headers */ = {isa = PBXBuildFile; fileRef = 512DD8EB0D91E6AF000F89EE /* LegacyWebArchive.h */; settings = {ATTRIBUTES = (Private, ); }; };
Looks unintentional.

WebCore/WebCore.xcodeproj/project.pbxproj: 
 +  				512DD8F50D91E6AF000F89EE /* LegacyWebArchive.h in Headers */,
Looks unintentional.

WebCore/dom/Document.cpp:1925
 +  #ifdef BUILDING_ON_LEOPARD
These need a FIXME before them, since the new treebuilder does not support these hacks and (currently) we have no plan to.

WebCore/html/HTMLTreeBuilder.cpp:52
 +  #include <wtf/dtoa.h>
You should mark this with a FIXME, no?

Otherwise looks fine.
Comment 3 Adam Barth 2010-08-24 15:27:50 PDT 
Committed r65941: <http://trac.webkit.org/changeset/65941>