Bug 44545 – [PATCH] Assert that WebKit chromium is not re-initialized

Bug 44545 - [PATCH] Assert that WebKit chromium is not re-initialized


Summary:	[PATCH] Assert that WebKit chromium is not re-initialized

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	WebKit Misc.
Version:	528+ (Nightly build)
Platform:	PC All

Importance:	P2 Minor
Assigned To:	Nobody

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-08-24 12:54 PDT by Paweł Hajdan, Jr.
Modified:	2010-08-25 04:53 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
assertion.patch (1.38 KB, patch) 2010-08-24 12:55 PDT, Paweł Hajdan, Jr.	fishd: review- phajdan.jr: commit‑queue-	Details \| Formatted Diff \| Diff
assertion.patch (1.43 KB, patch) 2010-08-24 12:59 PDT, Paweł Hajdan, Jr.	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paweł Hajdan, Jr. 2010-08-24 12:54:22 PDT

We should assert that WebKit chromium is not re-initialized to prevent crashes like these:

http://code.google.com/p/chromium/issues/detail?id=52731
http://code.google.com/p/chromium/issues/detail?id=52643

Please note: the attached patch can not be committed yet, because it will break the chromium tree.
I'm just submiting early to get the review done. I will update this bug when the chromium tree is ready
to land this patch.

Comment 1 Paweł Hajdan, Jr. 2010-08-24 12:55:16 PDT

Created attachment 65309 [details]
assertion.patch

Not ready for commit yet, would break the chromium tree if rolled in.

Comment 2 Darin Fisher (:fishd, Google) 2010-08-24 12:56:59 PDT

Comment on attachment 65309 [details]
assertion.patch

WebKit/chromium/ChangeLog:5
 +          Add an assertion to prevent re-initializing WebKit.
please add a link here to the webkit bug for this change

otherwise, LGTM

Comment 3 Paweł Hajdan, Jr. 2010-08-24 12:59:31 PDT

Created attachment 65310 [details]
assertion.patch

Fixed review comment. Still not ready for commit.

Comment 4 WebKit Commit Bot 2010-08-25 04:52:55 PDT

Comment on attachment 65310 [details]
assertion.patch

Clearing flags on attachment: 65310

Committed r66006: <http://trac.webkit.org/changeset/66006>

Comment 5 WebKit Commit Bot 2010-08-25 04:53:00 PDT

All reviewed patches have been landed.  Closing bug.