Bug 44532 - Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
Summary: Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 09:46 PDT by Pavel Podivilov
Modified: 2010-08-25 05:17 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch. (14.83 KB, patch)
2010-08-24 09:59 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Proposed patch. (14.70 KB, patch)
2010-08-25 02:58 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
On -> on (14.70 KB, patch)
2010-08-25 03:19 PDT, Pavel Podivilov
pfeldman: review-
Details | Formatted Diff | Diff
+ strings (15.30 KB, patch)
2010-08-25 03:36 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-08-24 09:46:34 PDT
Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
Comment 1 Pavel Podivilov 2010-08-24 09:59:12 PDT
Created attachment 65287 [details]
Proposed patch.
Comment 2 Pavel Feldman 2010-08-24 10:27:11 PDT
Comment on attachment 65287 [details]
Proposed patch.

LayoutTests/inspector/dom-breakpoints.html:17
 +      element[name] = value;
I think this should be element.setAttribute
Comment 3 Pavel Podivilov 2010-08-25 02:58:47 PDT
Created attachment 65391 [details]
Proposed patch.
Comment 4 Pavel Podivilov 2010-08-25 02:59:38 PDT
(In reply to comment #2)
> (From update of attachment 65287 [details])
> LayoutTests/inspector/dom-breakpoints.html:17
>  +      element[name] = value;
> I think this should be element.setAttribute

done
Comment 5 Pavel Feldman 2010-08-25 03:16:02 PDT
Comment on attachment 65391 [details]
Proposed patch.

WebCore/inspector/front-end/ElementsTreeOutline.js:769
 +              contextMenu.appendItem(WebInspector.UIString("Stop On Subtree Modifications"),
Stop _on_
Comment 6 Pavel Podivilov 2010-08-25 03:19:07 PDT
Created attachment 65392 [details]
On -> on
Comment 7 Pavel Feldman 2010-08-25 03:26:58 PDT
Comment on attachment 65392 [details]
On -> on

It does not seem to have localized strings changes.
Comment 8 Pavel Podivilov 2010-08-25 03:36:52 PDT
Created attachment 65395 [details]
+ strings
Comment 9 Pavel Feldman 2010-08-25 05:17:02 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/http/tests/inspector/debugger-test2.js
	M	LayoutTests/http/tests/inspector/inspector-test2.js
	M	LayoutTests/inspector/dom-breakpoints-expected.txt
	M	LayoutTests/inspector/dom-breakpoints.html
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
Committed r66008