Bug 44530 – [Win] No interface definition for WebFrame

• Status: UNCONFIRMED
• Component: WebKit API

[Peter Nelson]

Currently there is no coclass definition for the WebFrame class in WebKit/win/Interfaces/WebKit.idl.

Without this, the .NET type library importer tool does not appear to import the IWebFramePrivate interface or WebFramePrivate class.

[Peter Nelson]

Created attachment 65285 [details]
Added coclass definition for the WebFrame class

[WebKit Review Bot]

Attachment 65285 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/win/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKit/win/Interfaces/WebKit.idl:168:  Line contains tab character.  [whitespace/tab] [5]
WebKit/win/Interfaces/WebKit.idl:169:  Line contains tab character.  [whitespace/tab] [5]
WebKit/win/Interfaces/WebKit.idl:170:  Line contains tab character.  [whitespace/tab] [5]
WebKit/win/Interfaces/WebKit.idl:171:  Line contains tab character.  [whitespace/tab] [5]
WebKit/win/Interfaces/WebKit.idl:172:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Peter Nelson]

Created attachment 65288 [details]
Added coclass definition for the WebFrame class (+style fixes :-))

[Adam Barth]

This seems reasonable, but I don't understand this issue enough to review this patch.

[Brian Weinstein]

Comment on attachment 65288 [details]
Added coclass definition for the WebFrame class (+style fixes :-))

View in context: https://bugs.webkit.org/attachment.cgi?id=65288&action=review

> WebKit/win/ChangeLog:6
> +        Add WebFrame coclass definition to WebKit.idl
> +        https://bugs.webkit.org/show_bug.cgi?id=44530

It might be nice to explain the benefit of adding the coclass definition here, instead of only having that information in the bug.

[Adam Roben (:aroben)]

We currently only have coclass declarations for classes that we want to allow to be instantiated via CoCreateInstance. WebFrame is not one of those classes. Is there some other way to make it available to .NET?

[Eric Seidel (no email)]

Comment on attachment 65288 [details]
Added coclass definition for the WebFrame class (+style fixes :-))

Yes, the ChangLog should always explain why.