Bug 44527 – [Qt] Implement WebKit::Module for qt

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Balazs Kelemen]

First step of making plugins work in WebKit2.

[Balazs Kelemen]

Created attachment 65281 [details]
proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 65281 [details]
proposed patch

WebKit2/Platform/qt/ModuleQt.cpp:34
 +      // Try to remove the file suffix if the path contains it.
Try removing... 

You don't say why.

WebKit2/Platform/qt/ModuleQt.cpp:35
 +      QString path = static_cast<QString>(m_path);
What is m_path?

WebKit2/Platform/qt/ModuleQt.cpp:37
 +      if ((lastIndex = path.lastIndexOf(QString(".so"))) >= 0)
QLatin1String please

WebKit2/Platform/qt/ModuleQt.cpp:39
 +      else if ((lastIndex = path.lastIndexOf(QString(".dll"))) >= 0)
Same here

Apart from this it looks sane.

[Balazs Kelemen]

(In reply to comment #2)
> (From update of attachment 65281 [details])
> WebKit2/Platform/qt/ModuleQt.cpp:34
>  +      // Try to remove the file suffix if the path contains it.
> Try removing... 
> 
> You don't say why.
> 
> WebKit2/Platform/qt/ModuleQt.cpp:35
>  +      QString path = static_cast<QString>(m_path);
> What is m_path?

The filename (with path) of the library we want to load.
Actually, I have found out that we can assure that the path is good for QLibrary in UIProcess/Plugins/PluginInfoQt.cpp so the whole string stuff is useless here. I will remove that in the next patch.

[Balazs Kelemen]

Created attachment 65289 [details]
proposed patch

[WebKit Commit Bot]

Comment on attachment 65289 [details]
proposed patch

Clearing flags on attachment: 65289

Committed r65998: <http://trac.webkit.org/changeset/65998>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.