Bug 44525 - Accelerated 2D canvas should work without accelerated compositing
Summary: Accelerated 2D canvas should work without accelerated compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 08:39 PDT by Stephen White
Modified: 2010-08-24 12:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.55 KB, patch)
2010-08-24 09:02 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2010-08-24 10:34 PDT, Stephen White 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-08-24 08:39:37 PDT 
It should be possible to run with --enable-accelerated-2d-canvas but not --enable-accelerated-compositing.  It doesn't have to be fast (will use readback and software compositing), but it should work.
Comment 1 Stephen White 2010-08-24 09:02:11 PDT 
Created attachment 65279 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-24 09:53:34 PDT 
Attachment 65279 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3776570
Comment 3 Stephen White 2010-08-24 10:34:19 PDT 
Created attachment 65293 [details]
Patch
Comment 4 James Robinson 2010-08-24 10:35:33 PDT 
Looks good to me!
Comment 5 Kenneth Russell 2010-08-24 11:52:35 PDT 
Comment on attachment 65293 [details]
Patch

Looks good to me.
Comment 6 Stephen White 2010-08-24 12:17:47 PDT 
Committed r65921: <http://trac.webkit.org/changeset/65921>