Web Inspector: don't stop on DOM breakpoints when all breakpoints are deactivated
Created attachment 65251 [details] Proposed patch.
Comment on attachment 65251 [details] Proposed patch. WebCore/bindings/v8/ScriptDebugServer.cpp:202 + m_breakpointsActivated = activated; If we cannot make do without the flag in ScriptDebugServer, why not use only it without one in V8? This way you wouldn't need to reset "breakpoints activated" flag each time debugger agent is being created, this would also allow to deactivate breakpoints for one page while leaving them active in other pages being rendered by the same process.
Created attachment 65256 [details] Add fixme.
(In reply to comment #2) > (From update of attachment 65251 [details]) > WebCore/bindings/v8/ScriptDebugServer.cpp:202 > + m_breakpointsActivated = activated; > If we cannot make do without the flag in ScriptDebugServer, why not use only it without one in V8? This way you wouldn't need to reset "breakpoints activated" flag each time debugger agent is being created, this would also allow to deactivate breakpoints for one page while leaving them active in other pages being rendered by the same process. The flag in ScriptDebugServer is used to skip native breakpoints (e.g. DOM). We may continue using V8 flag for javascript breakpoints for better performance. Added FIXME for https://bugs.webkit.org/show_bug.cgi?id=44513.
Comment on attachment 65256 [details] Add fixme. Rejecting patch 65256 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20917 test cases. http/tests/security/xssAuditor/dom-write-location-inline-event.html -> failed Exiting early after 1 failures. 20565 tests run. 728.58s total testing time 20564 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 35 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3767583
Comment on attachment 65256 [details] Add fixme. Rejecting patch 65256 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: tTests Testing 20923 test cases. media/video-click-dblckick-standalone.html -> timed out Sampling process 6475 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 6475 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 17237 tests run. 658.01s total testing time 17236 test cases (99%) succeeded 1 test case (<1%) timed out 27 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3737580
Comment on attachment 65256 [details] Add fixme. Clearing flags on attachment: 65256 Committed r66013: <http://trac.webkit.org/changeset/66013>
All reviewed patches have been landed. Closing bug.