Bug 44501 - Deploy adoptPtr in WebCore/editing
Summary: Deploy adoptPtr in WebCore/editing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-24 01:45 PDT by Adam Barth
Modified: 2010-08-24 13:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2010-08-24 01:47 PDT, Adam Barth 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-24 01:45:46 PDT 
Deploy adoptPtr in WebCore/editing
Comment 1 Adam Barth 2010-08-24 01:47:19 PDT 
Created attachment 65237 [details]
Patch
Comment 2 Adam Barth 2010-08-24 11:37:42 PDT 
Comment on attachment 65237 [details]
Patch

Clearing flags on attachment: 65237

Committed r65919: <http://trac.webkit.org/changeset/65919>
Comment 3 Adam Barth 2010-08-24 11:37:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2010-08-24 11:41:03 PDT 
Comment on attachment 65237 [details]
Patch

Rejecting patch 65237 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65237, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
cgi?id=65237&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=44501&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 65237 from bug 44501.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Darin Adler 2010-08-24 12:30:16 PDT 
The call to clear() seems unneeded.
Comment 6 Adam Barth 2010-08-24 13:31:10 PDT 
(In reply to comment #5)
> The call to clear() seems unneeded.

Bug 44548.