Bug 44499 – Web Inspector: RemoteInspectorFrontend can be renamed to InspectorFrontend

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

As far as old version of InspectorFrontend was removed it is possible to rename RemoteInspectorFrontend to InspectorFrontend.

[Ilya Tikhonovsky]

Created attachment 65243 [details]
[patch] initial version.

[Ilya Tikhonovsky]

Comment on attachment 65243 [details]
[patch] initial version.

just for trybots

[Ilya Tikhonovsky]

	M	WebCore/WebCore.pri
	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.gyp/WebCore.gyp
	M	WebCore/inspector/InspectorDebuggerAgent.h
	M	WebCore/inspector/InspectorCSSStore.h
	M	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/InspectorDatabaseResource.cpp
	M	WebCore/inspector/InspectorDOMStorageResource.cpp
	M	WebCore/inspector/ConsoleMessage.cpp
	M	WebCore/inspector/InjectedScriptHost.cpp
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorStorageAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorResource.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorProfilerAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/InspectorDebuggerAgent.cpp
	M	WebCore/inspector/InspectorCSSStore.cpp
	M	WebCore/inspector/InspectorApplicationCacheAgent.h
	M	WebCore/inspector/InspectorDOMStorageResource.h
	M	WebCore/inspector/InspectorDatabaseResource.h
	M	WebCore/inspector/ConsoleMessage.h
	M	WebCore/inspector/InjectedScriptHost.h
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorStorageAgent.h
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/InspectorResource.h
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorApplicationCacheAgent.cpp
	M	WebCore/inspector/InspectorProfilerAgent.h
	M	WebCore/WebCore.xcodeproj/project.pbxproj
r65891 = b3d4ff4c0681a22b19fbd7e3f349b860201a09a9 (refs/remotes/trunk)

[WebKit Review Bot]

http://trac.webkit.org/changeset/65891 might have broken Leopard Intel Release (Tests)

[Joseph Pecoraro]

This looks like it forgot DerivedSources.make. Might changes have been necessary
to that file? It still has rules to generate it:
http://trac.webkit.org/browser/trunk/WebCore/DerivedSources.make#L822

> Remote%Frontend.h : %.idl $(INSPECTOR_GENERATOR_SCRIPTS)
>    $(call generator_script, $(INSPECTOR_GENERATOR_SCRIPTS)) --outputDir .  --defines "$(FEATURE_DEFINES) LANGUAGE_JAVASCRIPT" --generator Inspector $<

[Joseph Pecoraro]

Created attachment 65326 [details]
[PATCH] Follow up for DerivedSources.make

[Joseph Pecoraro]

Reopening due to the problem above. Its possible other build systems may be affected as well, but I don't know them very well.

[Joseph Pecoraro]

Committed r65943
	M	WebCore/ChangeLog
	M	WebCore/DerivedSources.make
r65943 = 5c75698d9813289ccc53ad7f367c6b3d2a3c60fd
http://trac.webkit.org/changeset/65943

Ilya, you are more familiar with the different build systems that were changed
for RemoteInspectorFrontend (since you added it). When you get in tomorrow,
it would be great if you could do a quick check to see if any other build systems
may need to be updated. Thanks!

[Ilya Tikhonovsky]

(In reply to comment #8)
> Committed r65943
>     M    WebCore/ChangeLog
>     M    WebCore/DerivedSources.make
> r65943 = 5c75698d9813289ccc53ad7f367c6b3d2a3c60fd
> http://trac.webkit.org/changeset/65943
> 
> Ilya, you are more familiar with the different build systems that were changed
> for RemoteInspectorFrontend (since you added it). When you get in tomorrow,
> it would be great if you could do a quick check to see if any other build systems
> may need to be updated. Thanks!

Thanks a lot. Looks like it was the only place which I missed in my patch.
This problem forced the build-system to generate the new version of inspector related files even if Inspector.idl has not been updated.