[EFL] Crash while hiding popup

[Krzysztof Czech]

Created attachment 65221 [details]
Patch corrects a crash while calling PopupMenuEfl destructor

The attached patch prevents crash when PopupMenuEfl's destructor is called. It was noticed that in some
circumstances popup menu is not shown and while destroying it, destructor tries to use undefined view to hide popup

[Gyuyoung Kim]

You have to write bug's title, url and summary in Changelog as below,

 2010-08-22  Rafael Antognolli  <[e-mail]>
  2 
  3         Reviewed by Antonio Gomes.
  4 
  5         [EFL] Remove duplicated include entry from default theme.
  6         https://bugs.webkit.org/show_bug.cgi?id=44345
  7 
  8         This used to create the group webkit/widget/entry twice in
  9         the theme. It's leading to a bug with the newer versions of
 10         EFL.
 11 
 12         * DefaultTheme/default.edc:


Please add "[EFL]" prefix to this bug's title.

[Krzysztof Czech]

Created attachment 65230 [details]
This patch corrects crash while hiding popup

[Lucas De Marchi]

(In reply to comment #2)
> Created an attachment (id=65230) [details]
> This patch corrects crash while hiding popup

As far as I remember, there's no way to destroy the Popup with no view defined (or the behavior changed in WebCore since its implementation). Could you provide a stack trace when it crashes?

[Krzysztof Czech]

The trace is as follows:
1. Load www.wikipedia.org
2. Input text in search box (it was emphasized that "test" should be written), but it happens in any other
3. press "->" button next to the search

This is a part of debug backtrace:
#0  0x4069b90c in WebCore::PopupMenu::hide() () from /usr/lib/libewebkit.so.0
#1  0x4069b938 in WebCore::PopupMenu::~PopupMenu() ()
   from /usr/lib/libewebkit.so.0
#2  0x4065ab18 in WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine() () from /usr/lib/libewebkit.so.0
#3  0x406339d0 in WebCore::RenderObject::arenaDelete(WebCore::RenderArena*, void*) () from /usr/lib/libewebkit.so.0
#4  0x403195e0 in WebCore::Node::detach() () from /usr/lib/libewebkit.so.0
#5  0x40305208 in WebCore::Element::detach() () from /usr/lib/libewebkit.so.0
...

[Lucas De Marchi]

(In reply to comment #4)
> The trace is as follows:
> 1. Load www.wikipedia.org
> 2. Input text in search box (it was emphasized that "test" should be written), but it happens in any other
> 3. press "->" button next to the search
> 
> This is a part of debug backtrace:
> #0  0x4069b90c in WebCore::PopupMenu::hide() () from /usr/lib/libewebkit.so.0
> #1  0x4069b938 in WebCore::PopupMenu::~PopupMenu() ()
>    from /usr/lib/libewebkit.so.0
> #2  0x4065ab18 in WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine() () from /usr/lib/libewebkit.so.0
> #3  0x406339d0 in WebCore::RenderObject::arenaDelete(WebCore::RenderArena*, void*) () from /usr/lib/libewebkit.so.0
> #4  0x403195e0 in WebCore::Node::detach() () from /usr/lib/libewebkit.so.0
> #5  0x40305208 in WebCore::Element::detach() () from /usr/lib/libewebkit.so.0
> ...

Humn... maybe it's something related to bug 43324.

I'm not a reviewer, just a informal r+. I'm CCing some reviewers.

[WebKit Commit Bot]

Comment on attachment 65230 [details]
This patch corrects crash while hiding popup

Clearing flags on attachment: 65230

Committed r66042: <http://trac.webkit.org/changeset/66042>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66042 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66041
http://trac.webkit.org/changeset/66042