Bug 44491 - Deploy adoptPtr in WebCore/storage
Summary: Deploy adoptPtr in WebCore/storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 23:37 PDT by Adam Barth
Modified: 2010-08-24 00:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (13.79 KB, patch)
2010-08-23 23:38 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (13.73 KB, patch)
2010-08-23 23:50 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-23 23:37:16 PDT
Deploy adoptPtr in WebCore/storage
Comment 1 Adam Barth 2010-08-23 23:38:45 PDT
Created attachment 65216 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-08-23 23:41:17 PDT
Comment on attachment 65216 [details]
Patch

I'm confused.  Were some of these leaks before?

Also you use leakPtr, yet you say it's not defined.
Comment 3 Adam Barth 2010-08-23 23:50:20 PDT
Created attachment 65218 [details]
Patch
Comment 4 Eric Seidel (no email) 2010-08-23 23:57:22 PDT
Comment on attachment 65218 [details]
Patch

Using adoptPtr outside of create() seems like a bad idea.  I guess you're going to move all this code into create methods next?
Comment 5 Adam Barth 2010-08-24 00:00:00 PDT
Comment on attachment 65218 [details]
Patch

Yes.  This patch is just easier to do first.
Comment 6 Adam Barth 2010-08-24 00:35:07 PDT
Comment on attachment 65218 [details]
Patch

Clearing flags on attachment: 65218

Committed r65871: <http://trac.webkit.org/changeset/65871>
Comment 7 Adam Barth 2010-08-24 00:35:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-08-24 00:53:44 PDT
http://trac.webkit.org/changeset/65871 might have broken Chromium Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/65872
http://trac.webkit.org/changeset/65871