Bug 44477 - HTMLTokenizer::create
Summary: HTMLTokenizer::create
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 18:34 PDT by Adam Barth
Modified: 2010-08-24 13:49 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.74 KB, patch)
2010-08-23 18:35 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-23 18:34:58 PDT
HTMLTokenizer::create
Comment 1 Adam Barth 2010-08-23 18:35:57 PDT
Created attachment 65198 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-08-24 13:32:56 PDT
Comment on attachment 65198 [details]
Patch

Can you remove an HTMLTokenizer.h include from WebCore/html/HTMLPreloadScanner.h now?

Can ~HTMLTokenizer() be private since it's always called by RefPtr?
Comment 3 Eric Seidel (no email) 2010-08-24 13:33:25 PDT
Comment on attachment 65198 [details]
Patch

Otherwise LGTM.
Comment 4 Adam Barth 2010-08-24 13:49:32 PDT
Comment on attachment 65198 [details]
Patch

Clearing flags on attachment: 65198

Committed r65932: <http://trac.webkit.org/changeset/65932>
Comment 5 Adam Barth 2010-08-24 13:49:36 PDT
All reviewed patches have been landed.  Closing bug.